Fix comparison/buffer size calculation in snprintf calls#7
Open
mu-b wants to merge 1 commit intoopenwrt:masterfrom
Open
Fix comparison/buffer size calculation in snprintf calls#7mu-b wants to merge 1 commit intoopenwrt:masterfrom
mu-b wants to merge 1 commit intoopenwrt:masterfrom
Conversation
Fixes an obviously incorrect comparison checking the return value from socket(). Also, some bad arithmetic in the snprintf for ifb name (needs looking at! don't quite know what you intend here) otherwise for certain values of 'len' your reading a negative offset. Signed-off-by: Neil Kettle <neil@digit-labs.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an obviously incorrect comparison checking the return value from socket(). Also, some bad arithmetic in the snprintf for ifb name (needs looking at! don't quite know what you intend here) otherwise for certain values of 'len' your reading a negative offset.