Skip to content

tests: unhide shunit2 test failures#22

Open
wififreedom wants to merge 1 commit intoopenwrt:masterfrom
wififreedom:fix_tests
Open

tests: unhide shunit2 test failures#22
wififreedom wants to merge 1 commit intoopenwrt:masterfrom
wififreedom:fix_tests

Conversation

@wififreedom
Copy link
Copy Markdown

Fix for issue #21

shunit2 test with failing subtest incorrectly produced:

      Start 2: shunit2
  2/2 Test #2: shunit2 ..........................   Passed   52.70 sec

  100% tests passed, 0 tests failed out of 2

now correctly produces:

      Start 2: shunit2
  2/2 Test #2: shunit2 ..........................***Failed   53.68 sec
  #
  # Performing tests
  #
  ...
  test_get_option
  ASSERT:expected:<badval> but was:<val>
  test_get_option_multiline
  ...

  #
  # Test report
  #
  tests passed:   111  99%
  tests failed:     1   1%
  tests skipped:    0   0%
  tests total:    112 100%

  50% tests passed, 1 tests failed out of 2

  Total Test time (real) =  59.67 sec

  The following tests FAILED:
        2 - shunit2 (Failed)
  Errors while running CTest
  make: *** [Makefile:74: test] Error 8
  make: Leaving directory '/home/user/repos/uci/build'

shunit2 test with failing subtest incorrectly produced:

      Start 2: shunit2
  2/2 Test openwrt#2: shunit2 ..........................   Passed   52.70 sec

  100% tests passed, 0 tests failed out of 2

now correctly produces:

      Start 2: shunit2
  2/2 Test openwrt#2: shunit2 ..........................***Failed   53.68 sec
  #
  # Performing tests
  #
  ...
  test_get_option
  ASSERT:expected:<badval> but was:<val>
  test_get_option_multiline
  ...

  #
  # Test report
  #
  tests passed:   111  99%
  tests failed:     1   1%
  tests skipped:    0   0%
  tests total:    112 100%

  50% tests passed, 1 tests failed out of 2

  Total Test time (real) =  59.67 sec

  The following tests FAILED:
        2 - shunit2 (Failed)
  Errors while running CTest
  make: *** [Makefile:74: test] Error 8
  make: Leaving directory '/home/user/repos/uci/build'

Signed-off-by: Bastiaan Stougie <wififreedom2026@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant