Skip to content

implement API/UI to list, create, view and edit collections#269

Open
elfkuzco wants to merge 3 commits into
mainfrom
collections-management
Open

implement API/UI to list, create, view and edit collections#269
elfkuzco wants to merge 3 commits into
mainfrom
collections-management

Conversation

@elfkuzco
Copy link
Copy Markdown
Contributor

@elfkuzco elfkuzco commented May 5, 2026

Rationale

This PR implements logic to list, view, create and edit collections in the API and UI

Screenshot_20260505_152816 Screenshot_20260505_152808 Screenshot_20260505_152748 Screenshot_20260505_152739

Changes

  • make warehouse name a unique column in the DB
  • make events list component stripe adapt to dark theme
  • add views/routes for viewing list of collections and collection detail
  • add new permission for collection to Editor Role

This closes #244

@elfkuzco elfkuzco self-assigned this May 5, 2026
@elfkuzco elfkuzco requested a review from benoit74 May 5, 2026 15:26
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

❌ Patch coverage is 82.90598% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.28%. Comparing base (53ad7cf) to head (c31ba07).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
backend/src/cms_backend/db/collection.py 64.10% 12 Missing and 2 partials ⚠️
backend/src/cms_backend/api/routes/collection.py 93.93% 1 Missing and 1 partial ⚠️
backend/src/cms_backend/api/routes/warehouse.py 83.33% 2 Missing ⚠️
backend/src/cms_backend/db/warehouse.py 88.88% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #269      +/-   ##
==========================================
- Coverage   81.39%   81.28%   -0.12%     
==========================================
  Files          55       57       +2     
  Lines        2354     2463     +109     
  Branches      233      242       +9     
==========================================
+ Hits         1916     2002      +86     
- Misses        378      396      +18     
- Partials       60       65       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, some enhancements:

  • in TitlesFilters, we should rather use a "select" component since the list of collections is going to be very limited and it will be way more convenient for the user
  • the "clear filters" button is still grayed-out when a collection is specified in the filter
  • when creating a new collection or editing an existing one, the UI could check for collection name conflicts to prevent user trying silly things ; even if collection name is case sensitive, UI should make the comparison case-insensitive

@elfkuzco
Copy link
Copy Markdown
Contributor Author

Refactored things a bit more by merging the component to create/edit collections too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement collection management screens

2 participants