Add OEX compatibility to conversion process + ship minified versions of the JS library files#9
Open
richtr wants to merge 3 commits into
Open
Add OEX compatibility to conversion process + ship minified versions of the JS library files#9richtr wants to merge 3 commits into
richtr wants to merge 3 commits into
Conversation
… in to a .oex file will now successfully run in legacy Opera <= 12.15)
Contributor
|
OK, I was in the wrong branch when I got those failures. So now I'm going to delete that comment for realz. The actual failures are: So basically we didn't want the config.xml to be there before, but we want it now @richtr? I can update the tests if that's the case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these commits a developer can, if they wish to, zip up a .nex converted output directory as a .oex file and this .oex file containing the .nex code will run successfully in Opera versions <= 12.15 (in addition to being able to run as a .nex file in Opera > 12.15 of course). ;)
This pull request supersedes pull request #8 (if you merge this fix then we can discard pull request #8 since it includes the same commits as this super-set pull request).