Skip to content

improve: add missing config params#301

Open
csviri wants to merge 1 commit into
mainfrom
params
Open

improve: add missing config params#301
csviri wants to merge 1 commit into
mainfrom
params

Conversation

@csviri
Copy link
Copy Markdown
Contributor

@csviri csviri commented May 15, 2026

Signed-off-by: Attila Mészáros a_meszaros@apple.com

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
Copy link
Copy Markdown
Contributor Author

csviri commented May 17, 2026

cc @xstefank

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR exposes several additional configuration options from the Java Operator SDK through the Spring Boot starter, so that users can configure them via application.yaml. Both operator-level and reconciler-level properties are added, wired into the ConfigurationServiceOverrider/ControllerConfigurationOverrider, and covered by new tests.

Changes:

  • Add four operator-level properties (reconciliationTerminationTimeout, ssaBasedCreateUpdateMatchForDependentResources, useSSAToPatchPrimaryResource, cloneSecondaryResourcesWhenGettingFromCache) and three reconciler-level properties (fieldManager, triggerReconcilerOnAllEvents, informerListLimit) with getters/setters.
  • Wire the new properties into the auto-configuration overriders so they are applied to the runtime.
  • Add tests asserting both binding from YAML and propagation to the underlying configuration; simplify TestReconciler by dropping the unused Cleaner implementation.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
starter/src/main/java/io/javaoperatorsdk/operator/springboot/starter/OperatorConfigurationProperties.java Adds four new operator-level fields with getters/setters.
starter/src/main/java/io/javaoperatorsdk/operator/springboot/starter/ReconcilerProperties.java Adds three new reconciler-level fields with getters/setters.
starter/src/main/java/io/javaoperatorsdk/operator/springboot/starter/OperatorAutoConfiguration.java Applies new properties via the configuration/controller overriders.
starter/src/test/resources/application.yaml Provides test values for the new operator- and reconciler-level properties.
starter/src/test/java/io/javaoperatorsdk/operator/springboot/starter/AutoConfigurationTest.java Adds three tests covering property binding and propagation.
starter/src/test/java/io/javaoperatorsdk/operator/springboot/starter/TestReconciler.java Removes unused Cleaner interface implementation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants