Conversation
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Contributor
Author
|
cc @xstefank |
There was a problem hiding this comment.
Pull request overview
This PR exposes several additional configuration options from the Java Operator SDK through the Spring Boot starter, so that users can configure them via application.yaml. Both operator-level and reconciler-level properties are added, wired into the ConfigurationServiceOverrider/ControllerConfigurationOverrider, and covered by new tests.
Changes:
- Add four operator-level properties (
reconciliationTerminationTimeout,ssaBasedCreateUpdateMatchForDependentResources,useSSAToPatchPrimaryResource,cloneSecondaryResourcesWhenGettingFromCache) and three reconciler-level properties (fieldManager,triggerReconcilerOnAllEvents,informerListLimit) with getters/setters. - Wire the new properties into the auto-configuration overriders so they are applied to the runtime.
- Add tests asserting both binding from YAML and propagation to the underlying configuration; simplify
TestReconcilerby dropping the unusedCleanerimplementation.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| starter/src/main/java/io/javaoperatorsdk/operator/springboot/starter/OperatorConfigurationProperties.java | Adds four new operator-level fields with getters/setters. |
| starter/src/main/java/io/javaoperatorsdk/operator/springboot/starter/ReconcilerProperties.java | Adds three new reconciler-level fields with getters/setters. |
| starter/src/main/java/io/javaoperatorsdk/operator/springboot/starter/OperatorAutoConfiguration.java | Applies new properties via the configuration/controller overriders. |
| starter/src/test/resources/application.yaml | Provides test values for the new operator- and reconciler-level properties. |
| starter/src/test/java/io/javaoperatorsdk/operator/springboot/starter/AutoConfigurationTest.java | Adds three tests covering property binding and propagation. |
| starter/src/test/java/io/javaoperatorsdk/operator/springboot/starter/TestReconciler.java | Removes unused Cleaner interface implementation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
xstefank
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Attila Mészáros a_meszaros@apple.com