-
Notifications
You must be signed in to change notification settings - Fork 70
🐛 Prevent showing duplicate entry under .status.activeRevisions
#2444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Prevent showing duplicate entry under .status.activeRevisions
#2444
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
901ebcc to
adc9a69
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2444 +/- ##
==========================================
- Coverage 73.00% 69.41% -3.59%
==========================================
Files 100 101 +1
Lines 7641 7719 +78
==========================================
- Hits 5578 5358 -220
- Misses 1625 1924 +299
+ Partials 438 437 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Updating `ClusterExtension` with duplicate entry under `.status.activeRevisions` fails. Thus, we repopulate it from the installed and rolling out revisions.
adc9a69 to
489a9e6
Compare
.status.activeRevisions
|
/lgtm |
|
/approve |
|
This codecov result is insane, considering that there is one line of modified code, with an associated test. I wonder if this is a grandfathered deficit which we see now because of the change in the module. |
rashmigottipati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn, rashmigottipati, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override codecov/project |
|
@pedjak: Overrode contexts on behalf of pedjak: codecov/project DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
da9e337
into
operator-framework:main
@pedjak this was not a required test, so it didn't block. Unfortunately, the |
Description
Updating
ClusterExtensionwith duplicate entry under.status.activeRevisionsfails.Thus, we repopulate it from the installed and rolling out revisions.
Reviewer Checklist