Skip to content

Conversation

@pedjak
Copy link
Contributor

@pedjak pedjak commented Jan 13, 2026

Description

Updating ClusterExtension with duplicate entry under .status.activeRevisions fails.
Thus, we repopulate it from the installed and rolling out revisions.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@netlify
Copy link

netlify bot commented Jan 13, 2026

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 489a9e6
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/69669574b2629a000822544c
😎 Deploy Preview https://deploy-preview-2444--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pedjak pedjak changed the title :fix: Prevent showing duplicate entry under .status.activeRevisions 🐛 : Prevent showing duplicate entry under .status.activeRevisions Jan 13, 2026
@pedjak pedjak changed the title 🐛 : Prevent showing duplicate entry under .status.activeRevisions 🐛 Prevent showing duplicate entry under .status.activeRevisions Jan 13, 2026
@pedjak pedjak force-pushed the fix-duplicate-active-revision-status branch from 901ebcc to adc9a69 Compare January 13, 2026 18:14
@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.41%. Comparing base (1fa4169) to head (489a9e6).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2444      +/-   ##
==========================================
- Coverage   73.00%   69.41%   -3.59%     
==========================================
  Files         100      101       +1     
  Lines        7641     7719      +78     
==========================================
- Hits         5578     5358     -220     
- Misses       1625     1924     +299     
+ Partials      438      437       -1     
Flag Coverage Δ
e2e 46.23% <0.00%> (-0.63%) ⬇️
experimental-e2e 13.52% <0.00%> (-35.17%) ⬇️
unit 57.04% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Updating `ClusterExtension` with duplicate entry under `.status.activeRevisions` fails.
Thus, we repopulate it from the installed and rolling out revisions.
@pedjak pedjak force-pushed the fix-duplicate-active-revision-status branch from adc9a69 to 489a9e6 Compare January 13, 2026 18:56
@pedjak pedjak changed the title 🐛 Prevent showing duplicate entry under .status.activeRevisions 🐛 Prevent showing duplicate entry under .status.activeRevisions Jan 13, 2026
@tmshort
Copy link
Contributor

tmshort commented Jan 13, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2026
@tmshort
Copy link
Contributor

tmshort commented Jan 13, 2026

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2026
@grokspawn
Copy link
Contributor

This codecov result is insane, considering that there is one line of modified code, with an associated test. I wonder if this is a grandfathered deficit which we see now because of the change in the module.

Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, rashmigottipati, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pedjak
Copy link
Contributor Author

pedjak commented Jan 13, 2026

/override codecov/project

@openshift-ci
Copy link

openshift-ci bot commented Jan 13, 2026

@pedjak: Overrode contexts on behalf of pedjak: codecov/project

Details

In response to this:

/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit da9e337 into operator-framework:main Jan 13, 2026
30 of 31 checks passed
@grokspawn
Copy link
Contributor

/override codecov/project

@pedjak this was not a required test, so it didn't block. Unfortunately, the /override command does not override GH branch protection required tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants