🌱 Simplify Boxcutter applier by removing status interpretation logic #2446
+16
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The Apply method now returns only an error instead of (bool, string, error). The responsibility for interpreting ClusterExtensionRevision status conditions is removed from the applier, simplifying the interface and making the applier focus solely on creating/updating revisions.
pedjak
force-pushed
the
simplify-boxcutter-applier
branch
from
74dac59 to
80fdbe8
Compare
pedjak
force-pushed
the
simplify-boxcutter-applier
branch
from
80fdbe8 to
aff9804
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Apply method now returns only an error instead of (bool, string, error).
The responsibility for interpreting ClusterExtensionRevision status conditions
is removed from the applier, simplifying the interface and making the applier
focus solely on creating/updating revisions.
Reviewer Checklist