test(dashboard-honesty): lock in /agents/builder + /settings DEMO disclosures#220
Merged
operatoruplift merged 1 commit intomasterfrom Apr 28, 2026
Merged
Conversation
…closures
Two new specs in dashboard-honesty.spec.ts that prevent the recent
honesty fixes from silently regressing:
1. /agents/builder Tools step
- Walks the wizard: pick General Assistant -> name + description ->
Tools step
- Asserts the four most-recognizable stub tools (Slack, Notion,
GitHub, Database) are still present
- Counts DEMO badges on the page; requires >= 5 (we marked 14 stubs
in #218; 5 is a defensive lower bound that protects the contract
without being brittle to category copy edits)
2. /settings API Keys section
- Navigates to the API tab
- Asserts the disclosure copy or DEMO badge is visible (regex
matches several phrasings so a future copy edit doesn't break it)
- Asserts the retired "expires in 30 days" wording is absent
Hermetic spec count stays at 17 — these are tests added to the existing
dashboard-honesty file that's already in the CI list.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two new specs in
dashboard-honesty.spec.tsthat prevent the recent honesty fixes from silently regressing:1.
/agents/builderTools step (PR #218 lock-in)2.
/settingsAPI Keys section (PR #212 lock-in)Hermetic spec count stays at 17 — these are added to the existing
dashboard-honestyspec already in CI.Test plan
pnpm checkpasses