Skip to content

fix(scoreboard): keep score centered regardless of logo size #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BungeeDEV wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(scoreboard): keep score centered regardless of logo size #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
140 changes: 96 additions & 44 deletions src/components/output/ScoreboardScene.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,38 +60,91 @@ function ScoreboardScene({ gameState, timerDisplay, homeLogoPath, guestLogoPath,
)}
</div>

{/* Row 2: Home Logo | Home Score | : | Away Score | Away Logo */}
<div style={{
display: 'flex',
justifyContent: 'center',
alignItems: 'center',
gap: '1cqw',
}}>
{/* Home Logo */}
<div style={{ display: 'flex', justifyContent: 'flex-end', alignItems: 'center' }}>
{homeLogoPath && (
<img
src={homeLogoPath}
alt="Home"
style={{ maxHeight: '50cqh', maxWidth: '40cqw', objectFit: 'contain' }}
/>
)}
{/* Row 2: Home Logo | Score (fix zentriert) | Away Logo */}
<div style={{ position: 'relative' }}>
{/* Logos – linke und rechte Hälfte */}
<div style={{
display: 'grid',
gridTemplateColumns: '1fr 1fr',
alignItems: 'center',
}}>
{/* Home Logo – nur linkes Drittel */}
<div style={{
position: 'absolute',
left: 0,
width: '30%', // nur linkes Drittel
top: 0,
bottom: 0,
display: 'flex',
justifyContent: 'flex-end',
alignItems: 'center',
paddingRight: '1cqw',
boxSizing: 'border-box',
}}>
{homeLogoPath && (
<img
src={homeLogoPath}
alt="Home"
style={{ maxHeight: '90%', maxWidth: '100%', objectFit: 'contain' }}
/>
)}
</div>

{/* Guest Logo – nur rechtes Drittel */}
<div style={{
position: 'absolute',
right: 0,
width: '30%', // nur rechtes Drittel
top: 0,
bottom: 0,
display: 'flex',
justifyContent: 'flex-start',
alignItems: 'center',
paddingLeft: '1cqw',
boxSizing: 'border-box',
}}>
{guestLogoPath && (
<img
src={guestLogoPath}
alt="Away"
style={{ maxHeight: '90%', maxWidth: '100%', objectFit: 'contain' }}
/>
)}
</div>
</div>

{/* Score */}
{/* Score – : exakt auf Mittellinie, Ziffern symmetrisch links/rechts */}
<div style={{
position: 'absolute',
left: 0,
right: 0,
top: '50%',
transform: 'translateY(-50%)',
display: 'flex',
justifyContent: 'center',
alignItems: 'center',
margin: '0 3cqw',
pointerEvents: 'none',
zIndex: 1,
}}>
<span style={{
color: '#fff',
fontSize: '40cqh',
fontWeight: 'bold',
fontFamily: 'monospace',
lineHeight: 1,
textShadow: '0 2px 8px rgba(0,0,0,0.8)',
}}>{gameState.homeScore}</span>
{/* Home Score */}
<div style={{
position: 'absolute',
right: '50%',
marginRight: '2cqw',
display: 'flex',
justifyContent: 'flex-end',
}}>
<span style={{
color: '#fff',
fontSize: '40cqh',
fontWeight: 'bold',
fontFamily: 'monospace',
lineHeight: 1,
textShadow: '0 2px 8px rgba(0,0,0,0.8)',
}}>{gameState.homeScore}</span>
</div>

{/* Doppelpunkt – exakt auf left: 50% */}
<span style={{
color: 'rgba(255,255,255,0.8)',
fontSize: '30cqh',
Expand All @@ -100,25 +153,24 @@ function ScoreboardScene({ gameState, timerDisplay, homeLogoPath, guestLogoPath,
lineHeight: 1,
textShadow: '0 2px 8px rgba(0,0,0,0.8)',
}}>:</span>
<span style={{
color: '#fff',
fontSize: '40cqh',
fontWeight: 'bold',
fontFamily: 'monospace',
lineHeight: 1,
textShadow: '0 2px 8px rgba(0,0,0,0.8)',
}}>{gameState.guestScore}</span>
</div>

{/* Away Logo */}
<div style={{ display: 'flex', justifyContent: 'flex-start', alignItems: 'center' }}>
{guestLogoPath && (
<img
src={guestLogoPath}
alt="Away"
style={{ maxHeight: '50cqh', maxWidth: '40cqw', objectFit: 'contain' }}
/>
)}
{/* Guest Score */}
<div style={{
position: 'absolute',
left: '50%',
marginLeft: '2cqw',
display: 'flex',
justifyContent: 'flex-start',
}}>
<span style={{
color: '#fff',
fontSize: '40cqh',
fontWeight: 'bold',
fontFamily: 'monospace',
lineHeight: 1,
textShadow: '0 2px 8px rgba(0,0,0,0.8)',
}}>{gameState.guestScore}</span>
</div>
</div>
</div>

Expand Down