Open
Conversation
…te branch This reverts commit 0dad586.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(builds on my other pull request for Box/Rc/Arc, but can be easily disentangled).
The blanket implementation for HashMaps has two too-narrow properties that can be generalized easily, as done by this pull requests:
HashMap<K,V>instead ofHashMap<K,V,S>, which doesn't allow for using popular hashing crates such as fxhash and rustc_hash,From<Cow<'static, str>>- this PR generalizes this toTryFromto allow for possibly fallible parsing of HashMap keys.The latter could be changed to requiring
serde_lite::Deserializeinstead, with the implicit contract that theIntermediateused has to be a string, but that would a breaking change, whereas everything else in this PR should be backwards compatible.