Skip to content

[73671][55638] Remove ui-router from Calendars and TeamPlanner#22674

Open
HDinger wants to merge 7 commits intodevfrom
code-maintenance/73671-remove-ui-router-from-calendars
Open

[73671][55638] Remove ui-router from Calendars and TeamPlanner#22674
HDinger wants to merge 7 commits intodevfrom
code-maintenance/73671-remove-ui-router-from-calendars

Conversation

@HDinger
Copy link
Copy Markdown
Contributor

@HDinger HDinger commented Apr 7, 2026

Ticket

https://community.openproject.org/wp/73671
https://community.openproject.org/wp/55638

What are you trying to accomplish?

  • Remove uiRouter from Calendars and the TeamPlanner module
    • Render the show route via Rails
    • Render the split screen via Rails
    • Render the split create via Rails
  • Primerize the /new route

Screenshots

Split view
Bildschirmfoto 2026-04-07 um 15 38 27

Split create
Bildschirmfoto 2026-04-14 um 15 17 51

Split view
Bildschirmfoto 2026-04-15 um 09 05 06

Split create
Bildschirmfoto 2026-04-15 um 09 04 49

What approach did you choose and why?

  • The show page use custom elements
  • The work package split view is now a rails route (details/:work_package_id) rendered in the
    content-bodyRight Turbo frame, similar to how notification center handles the split view.
  • There is now a split_create equivalent to how split_view was added in rails
    • The inner angular component takes care of reading the query_props when being routed via Rails
  • openproject-calendar.routes.ts has been deleted.
  • wp-list-checksum.service.ts: changes update URL via window.history.pushState instead of state.go

Base automatically changed from code-maintenance/73670-remove-ui-router-from-boards to dev April 7, 2026 13:42
@HDinger HDinger added this to the 17.4.x milestone Apr 7, 2026
@HDinger HDinger force-pushed the code-maintenance/73671-remove-ui-router-from-calendars branch 2 times, most recently from 5f0bf30 to 288b056 Compare April 13, 2026 07:21
Comment thread modules/calendar/app/views/calendar/calendars/show.html.erb Outdated
@HDinger HDinger force-pushed the code-maintenance/73671-remove-ui-router-from-calendars branch 2 times, most recently from 7fe5a95 to 282098a Compare April 13, 2026 14:06
@HDinger HDinger changed the title [73671] Remove ui-router from Calendars [73671][55638] Remove ui-router from Calendars and TeamPlanner Apr 16, 2026
@HDinger HDinger force-pushed the code-maintenance/73671-remove-ui-router-from-calendars branch 2 times, most recently from b0f35e7 to 9bc5ec9 Compare April 16, 2026 13:26
@HDinger HDinger marked this pull request as ready for review April 16, 2026 13:26
@HDinger HDinger force-pushed the code-maintenance/73671-remove-ui-router-from-calendars branch 6 times, most recently from 47ee252 to 307502f Compare April 17, 2026 09:12
@HDinger HDinger force-pushed the code-maintenance/73671-remove-ui-router-from-calendars branch from 307502f to 76e460a Compare April 17, 2026 09:25
Copy link
Copy Markdown
Member

@oliverguenther oliverguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. I have not found any issues while clicking through the main use cases. The additional logic to wire up the parameters to the split create looks fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants