[OP#73838] Introducing the Wikis::PageLinkRepresenter#22745
Merged
Conversation
mereghost
force-pushed
the
impl/73838-page-link-representer
branch
from
231c81f to
a723d84
Compare
mereghost
force-pushed
the
impl/73838-page-link-representer
branch
2 times, most recently
from
40df1b6 to
2251a33
Compare
6 tasks
NobodysNightmare
requested changes
Apr 15, 2026
Contributor
NobodysNightmare
left a comment
NobodysNightmare
left a comment
There was a problem hiding this comment.
My question about the view permission aside this mostly LGTM.
Do I understand this PR correctly in that it does not introduce the actual API endpoints but only the representers? I am not yet sure what you need those for :D
mereghost
force-pushed
the
impl/73838-page-link-representer
branch
from
0ff19ab to
2779064
Compare
…path for wiki links
…ntion revealingskip render if linkable is not a WP
mereghost
force-pushed
the
impl/73838-page-link-representer
branch
from
2779064 to
7c5c125
Compare
NobodysNightmare
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the
PageLinkRepresenterNothing too fancy here, just a plain renderer. I introduced the
#author?method toPageLinkas a quick cop-out if the author is relevant and should be rendered.It probably warrants at least a rename. 🤣
The
ProviderRepresenterfor now is also pretty simple, I just needed it to exist in order to be able to link the provider from the PageLink. It will be expanded in future PRs.