[59732] List is scrollable even if there is only 1 item#22814
Open
[59732] List is scrollable even if there is only 1 item#22814
Conversation
…the additional create option is displayed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } from 'core-app/features/work-packages/services/notifications/work-package-notification.service'; | ||
| import { InjectField } from 'core-app/shared/helpers/angular/inject-field.decorator'; | ||
| import { TOpAutocompleterResource } from 'core-app/shared/components/autocompleter/op-autocompleter/typings'; | ||
| import { NgDropdownPanelComponent } from '@ng-select/ng-select'; |
Comment on lines
+35
to
+38
| import { | ||
| NgDropdownPanelComponent, | ||
| NgSelectComponent, | ||
| } from '@ng-select/ng-select'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/59732
What are you trying to accomplish?
What approach did you choose and why?
ngSelect had quite same changes in the meantime. The biggest change was making
searchTermprivate. Thus we were forced to use thefiltermethod which directly opens the autocompleter. On the global search, that caused some issues as it initally opened the search on page load. That is why I did an ugly workaround and used the privatesearchTermthere.