Bump Primer to 0.90.1, Octicons to 19.36.0 - #24456
Conversation
0e4133a to
df3e037
Compare
|
Since this contains a bug fix for 17.7 , it should proabably target the release branch |
df3e037 to
1a9970b
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates OpenProject’s Primer/ViewComponent and Octicons dependencies (Ruby gems + frontend npm packages) to newer patch/minor releases, and aligns an existing RichTextArea form spec with the updated label for/field id behavior.
Changes:
- Bump
openproject-primer_view_componentsto0.90.1andopenproject-octicons/_helperto19.36.0in Ruby (Gemfile + lockfile). - Bump corresponding frontend packages (
@openproject/primer-view-components,@openproject/octicons-angular, and the@primer/view-componentsalias) to the same versions (package.json + lockfile). - Update
Primer::OpenProject::Forms::RichTextAreaspec to remove the pending and assert the new namespaced labelforvalue.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
spec/lib/primer/open_project/forms/rich_text_area_spec.rb |
Updates expectations for label for values after Primer bump; removes prior pending. |
Gemfile |
Bumps OpenProject-maintained Primer/Octicons gem version constraints. |
Gemfile.lock |
Locks bumped gem versions and updated dependency constraints/checksums. |
frontend/package.json |
Bumps frontend Primer/Octicons package versions (including @primer/view-components alias). |
frontend/package-lock.json |
Locks bumped npm package versions and updated metadata/peer dependency ranges. |
Files not reviewed (1)
- frontend/package-lock.json: Generated file
|
@HDinger this still needs manual checks - in addition to the test fixes. Please feel free to take over if you have time to do this. |
1a9970b to
58d9835
Compare
|
Hi @myabc I assume you forgot to rebase after switching the base branch? |
58d9835 to
a1b47d7
Compare
Fixed upstream via primer/view_components#3696
Primer 0.90.0 rewrote the CollapsibleHeader toggle from a div with `role="button"` carrying the title text into a real button labelled via `aria-labelledby`, so the wizard's selector matched nothing.
@HDinger the other way around actually.. rebased against the wrong branch. Please check again. |
a1b47d7 to
319d4b5
Compare
|
Warning This pull request does not link an OpenProject work package. Please add a link to the work package in the description, or reference it in the |
…r. The backlogs compnonents can thus use the condensed header style (which also semantically more correct)
ac0c4f7 to
aa54da8
Compare
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |

Ticket
What are you trying to accomplish?
Screenshots
What approach did you choose and why?
Merge checklist
--text-title-size-small, the body text to--text-body-size-medium, and removes the@container (max-width: 34rem)padding block, so narrow containers keep full padding. ~71 call sites; worth eyeballing the hover card, split view, date picker dialog and widget boxes.BorderBoxheaders — the toggle is now a realPrimer::Beta::Button(data-collapsible-toggle,aria-labelledby) instead of arole="button"div,toggleViaKeyboardis gone, andcountlost its defaultmr: 2. Verify click + keyboard toggling and header spacing in meetings, wikis and backlogs..CollapsibleHeader(meetings, wikis, backlogs) —modules/meeting/spec/support/pages/meetings/show.rbclicks the header element directly, and the click target moved.modules/wikis/app/components/wikis/collapsible_page_links_component.html.erb: it omitscollapsible_id, so the new toggle button renders an emptyaria-controls(and trips the deprecation warning).href—BaseComponentnow raisesArgumentErroroutside production forjavascript:/vbscript:schemes (nils the attribute in production).