Skip to content

Bump Primer to 0.90.1, Octicons to 19.36.0 - #24456

Merged
myabc merged 4 commits into
release/17.7from
housekeeping/bump-primer-0.90.1
Jul 29, 2026
Merged

Bump Primer to 0.90.1, Octicons to 19.36.0#24456
myabc merged 4 commits into
release/17.7from
housekeeping/bump-primer-0.90.1

Conversation

@myabc

@myabc myabc commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Ticket

What are you trying to accomplish?

Screenshots

What approach did you choose and why?

Merge checklist

  • Check Blankslates — 0.90.0 drops the heading to --text-title-size-small, the body text to --text-body-size-medium, and removes the @container (max-width: 34rem) padding block, so narrow containers keep full padding. ~71 call sites; worth eyeballing the hover card, split view, date picker dialog and widget boxes.
  • Check collapsible BorderBox headers — the toggle is now a real Primer::Beta::Button (data-collapsible-toggle, aria-labelledby) instead of a role="button" div, toggleViaKeyboard is gone, and count lost its default mr: 2. Verify click + keyboard toggling and header spacing in meetings, wikis and backlogs.
  • Run the feature specs that drive .CollapsibleHeader (meetings, wikis, backlogs) — modules/meeting/spec/support/pages/meetings/show.rb clicks the header element directly, and the click target moved.
  • Decide on modules/wikis/app/components/wikis/collapsible_page_links_component.html.erb: it omits collapsible_id, so the new toggle button renders an empty aria-controls (and trips the deprecation warning).
  • Sanity-check user-supplied URLs that end up in a Primer hrefBaseComponent now raises ArgumentError outside production for javascript:/vbscript: schemes (nils the attribute in production).
  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@myabc
myabc force-pushed the housekeeping/bump-primer-0.90.1 branch from 0e4133a to df3e037 Compare July 27, 2026 12:07
@HDinger

HDinger commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Since this contains a bug fix for 17.7 , it should proabably target the release branch

@HDinger HDinger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we messed somthing up with line height when making the chevron a real button
Image

@myabc
myabc force-pushed the housekeeping/bump-primer-0.90.1 branch from df3e037 to 1a9970b Compare July 27, 2026 13:01
@myabc
myabc changed the base branch from dev to release/17.7 July 27, 2026 13:01
@myabc
myabc requested a review from Copilot July 27, 2026 13:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates OpenProject’s Primer/ViewComponent and Octicons dependencies (Ruby gems + frontend npm packages) to newer patch/minor releases, and aligns an existing RichTextArea form spec with the updated label for/field id behavior.

Changes:

  • Bump openproject-primer_view_components to 0.90.1 and openproject-octicons/_helper to 19.36.0 in Ruby (Gemfile + lockfile).
  • Bump corresponding frontend packages (@openproject/primer-view-components, @openproject/octicons-angular, and the @primer/view-components alias) to the same versions (package.json + lockfile).
  • Update Primer::OpenProject::Forms::RichTextArea spec to remove the pending and assert the new namespaced label for value.

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
spec/lib/primer/open_project/forms/rich_text_area_spec.rb Updates expectations for label for values after Primer bump; removes prior pending.
Gemfile Bumps OpenProject-maintained Primer/Octicons gem version constraints.
Gemfile.lock Locks bumped gem versions and updated dependency constraints/checksums.
frontend/package.json Bumps frontend Primer/Octicons package versions (including @primer/view-components alias).
frontend/package-lock.json Locks bumped npm package versions and updated metadata/peer dependency ranges.
Files not reviewed (1)
  • frontend/package-lock.json: Generated file

@myabc

myabc commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

@HDinger this still needs manual checks - in addition to the test fixes. Please feel free to take over if you have time to do this.

@myabc
myabc requested a review from HDinger July 28, 2026 22:21
@myabc
myabc force-pushed the housekeeping/bump-primer-0.90.1 branch from 1a9970b to 58d9835 Compare July 28, 2026 22:25
Comment thread .github/workflows/brakeman-scan-core.yml Dismissed
Comment thread .github/workflows/crowdin.yml Dismissed
Comment thread .github/workflows/danger.yml Dismissed
Comment thread .github/workflows/docs.yaml Dismissed
Comment thread .github/workflows/docs.yaml Dismissed
Comment thread .github/workflows/openapi.yaml Dismissed
Comment thread .github/workflows/openapi.yaml Dismissed
Comment thread .github/workflows/rubocop-core.yml Dismissed
Comment thread .github/workflows/seed-all-locales.yml Dismissed
Comment thread .github/workflows/version-check.yml Dismissed
Comment thread app/models/projects/custom_fields.rb Fixed
Comment thread app/models/type/configuration_linkable.rb Fixed
@HDinger

HDinger commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Hi @myabc I assume you forgot to rebase after switching the base branch?

@HDinger
HDinger force-pushed the housekeeping/bump-primer-0.90.1 branch from 58d9835 to a1b47d7 Compare July 29, 2026 07:19
myabc added 3 commits July 29, 2026 09:21
Primer 0.90.0 rewrote the CollapsibleHeader toggle from a div with
`role="button"` carrying the title text into a real button labelled
via `aria-labelledby`, so the wizard's selector matched nothing.
@myabc

myabc commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

I assume you forgot to rebase after switching the base branch?

@HDinger the other way around actually.. rebased against the wrong branch. Please check again.

@myabc
myabc force-pushed the housekeeping/bump-primer-0.90.1 branch from a1b47d7 to 319d4b5 Compare July 29, 2026 07:37

@HDinger HDinger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

@HDinger
HDinger marked this pull request as ready for review July 29, 2026 08:22
@github-actions

Copy link
Copy Markdown

Warning

This pull request does not link an OpenProject work package.

Please add a link to the work package in the description, or reference it in the
title in square brackets, e.g. [SLUG-123] My title here.

…r. The backlogs compnonents can thus use the condensed header style (which also semantically more correct)
@myabc
myabc force-pushed the housekeeping/bump-primer-0.90.1 branch from ac0c4f7 to aa54da8 Compare July 29, 2026 09:13
@github-actions

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./modules/wikis/spec/features/admin/internal_provider_spec.rb[1:1]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #24456, linked for reference only):

- `rspec ./modules/wikis/spec/features/admin/internal_provider_spec.rb[1:1]`

Treat this as a standalone task, unrelated to PR #24456. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #24456 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @myabc to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @myabc, and request a review from @myabc.
On every commit, set @myabc as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

@myabc
myabc merged commit deddba1 into release/17.7 Jul 29, 2026
19 checks passed
@myabc
myabc deleted the housekeeping/bump-primer-0.90.1 branch July 29, 2026 09:51
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants