Maintenance: Reuse Primer clipboard-copy element for activity copy-link items - #24485
Draft
akabiru wants to merge 2 commits into
Draft
Maintenance: Reuse Primer clipboard-copy element for activity copy-link items#24485akabiru wants to merge 2 commits into
akabiru wants to merge 2 commits into
Conversation
The activities tab carried its own Stimulus controller for a single navigator.clipboard call, duplicating the clipboard-copy element the action menus elsewhere already use. Dropping it also fixes the revision entry's copy item, which pointed at a controller never mounted on its wrapper.
Contributor
|
@akabiru nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The activities tab shipped a dedicated Stimulus controller whose whole job was one
navigator.clipboard.writeTextcall, even though the copy-link action menus elsewhere (meetings, storages, SAML) already use Primer'sclipboard-copyelement for exactly this. The item and revision menu entries now render asclipboard-copywith the URL as their value, so the controller and the wrapper data attributes that fed it are gone.That also repairs the revision entry: its copy item referenced the item controller, which was never mounted on the revision wrapper, so clicking it did nothing. It now copies the absolute revision URL.
Added a component spec for the actions menu, which had no coverage before.