[#459] SettingView에서 내비게이션이 되지 않는 현상을 해결한다#480
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
이 풀 리퀘스트는 ProfileView의 상태 관리 및 내비게이션 로직을 ProfileViewCoordinator로 이관하여 아키텍처를 개선하는 내용을 담고 있습니다. 주요 피드백으로는 SettingView에만 국한된 router 환경 객체 주입 범위를 NavigationStack 전체로 확장하여 하위 뷰의 런타임 에러를 방지할 것과, navigationDestination에서 ViewModel이 매번 새로 생성되지 않도록 캐싱 로직을 도입할 것을 권장했습니다. 또한, @Bindable을 활용하여 수동 Binding 생성을 제거하고 가독성을 높이는 코드 개선 사항이 포함되었습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
📝 작업 내용
📌 요약
ProfileViewCoordinator추가SettingView내부 중복 destination 제거ProfileRoute기반으로 통합🔍 상세
MainView에서ProfileViewCoordinator생성 및ProfileView주입MainViewCoordinator에서 Profile 화면 전용 책임 제거ProfileView에서ProfileRoutedestination을 단일 지점으로 관리하도록 변경SettingView에서router.push(.theme / .pushNotification / .account)만 수행하도록 정리ThemeView가 Settings 화면과 동일한SettingViewModel상태를 사용하도록 연결PushNotificationSettingsViewModel,AccountViewModel은 상세 화면 진입 시 생성하도록 유지📸 영상 / 이미지 (Optional)
Simulator.Screen.Recording.-.iPad.Pro.13-inch.M5.-.2026-05-21.at.12.01.34.mov