Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Application/DevLogCore/DevLogCore.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,8 @@
/* Begin XCBuildConfiguration section */
0095EA3D0E3FC18B545418BE /* Debug */ = {
isa = XCBuildConfiguration;
baseConfigurationReferenceAnchor = DA0865721A6D430B66025E66 /* Sources */;
baseConfigurationReferenceRelativePath = Version.xcconfig;
buildSettings = {
CLANG_ENABLE_OBJC_WEAK = NO;
CURRENT_PROJECT_VERSION = 1;
Expand All @@ -188,6 +190,7 @@
"@executable_path/Frameworks",
"@loader_path/Frameworks",
);
MARKETING_VERSION = 1.2;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

현재 MARKETING_VERSION이 모든 내부 프레임워크 프로젝트 파일에 개별적으로 하드코딩되어 있습니다. 이는 향후 앱 버전 업데이트 시 모든 모듈의 프로젝트 파일을 일일이 수정해야 하는 번거로움이 있고, 일부 모듈에서 수정을 누락할 경우 버전 불일치 문제가 발생할 수 있습니다. 프로젝트 루트에 공통 .xcconfig 파일을 생성하고 모든 프로젝트에서 이를 참조하도록 하여 버전을 중앙에서 관리하는 방식을 고려해 보시기 바랍니다.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영 커밋

PRODUCT_BUNDLE_IDENTIFIER = com.opfic.DevLog.DevLogCore;
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = iphoneos;
Expand Down Expand Up @@ -255,6 +258,8 @@
};
CE0953D10C4F8C380398A44D /* Release */ = {
isa = XCBuildConfiguration;
baseConfigurationReferenceAnchor = DA0865721A6D430B66025E66 /* Sources */;
baseConfigurationReferenceRelativePath = Version.xcconfig;
buildSettings = {
CLANG_ENABLE_OBJC_WEAK = NO;
CURRENT_PROJECT_VERSION = 1;
Expand All @@ -270,6 +275,7 @@
"@executable_path/Frameworks",
"@loader_path/Frameworks",
);
MARKETING_VERSION = 1.2;
PRODUCT_BUNDLE_IDENTIFIER = com.opfic.DevLog.DevLogCore;
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = iphoneos;
Expand Down
1 change: 1 addition & 0 deletions Application/DevLogCore/Sources/Version.xcconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
#include "../../Shared/Version.xcconfig"
6 changes: 6 additions & 0 deletions Application/DevLogData/DevLogData.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,8 @@
};
1E63E77475382EF159DBD932 /* Debug */ = {
isa = XCBuildConfiguration;
baseConfigurationReferenceAnchor = 5A15B28E791BA16F53BAF94E /* Sources */;
baseConfigurationReferenceRelativePath = Version.xcconfig;
buildSettings = {
CLANG_ENABLE_OBJC_WEAK = NO;
CURRENT_PROJECT_VERSION = 1;
Expand All @@ -293,6 +295,7 @@
"@executable_path/Frameworks",
"@loader_path/Frameworks",
);
MARKETING_VERSION = 1.2;
PRODUCT_BUNDLE_IDENTIFIER = com.opfic.DevLog.DevLogData;
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = iphoneos;
Expand Down Expand Up @@ -421,6 +424,8 @@
};
D6BAE0518A7CBD73832246F3 /* Release */ = {
isa = XCBuildConfiguration;
baseConfigurationReferenceAnchor = 5A15B28E791BA16F53BAF94E /* Sources */;
baseConfigurationReferenceRelativePath = Version.xcconfig;
buildSettings = {
CLANG_ENABLE_OBJC_WEAK = NO;
CURRENT_PROJECT_VERSION = 1;
Expand All @@ -436,6 +441,7 @@
"@executable_path/Frameworks",
"@loader_path/Frameworks",
);
MARKETING_VERSION = 1.2;
PRODUCT_BUNDLE_IDENTIFIER = com.opfic.DevLog.DevLogData;
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = iphoneos;
Expand Down
1 change: 1 addition & 0 deletions Application/DevLogData/Sources/Version.xcconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
#include "../../Shared/Version.xcconfig"
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,8 @@
};
CE7099C63D3B75B186422932 /* Debug */ = {
isa = XCBuildConfiguration;
baseConfigurationReferenceAnchor = 534E4B81FFFA3D0023139ACE /* Sources */;
baseConfigurationReferenceRelativePath = Version.xcconfig;
buildSettings = {
CLANG_ENABLE_OBJC_WEAK = NO;
CURRENT_PROJECT_VERSION = 1;
Expand All @@ -403,6 +405,7 @@
"@executable_path/Frameworks",
"@loader_path/Frameworks",
);
MARKETING_VERSION = 1.2;
PRODUCT_BUNDLE_IDENTIFIER = com.opfic.DevLog.DevLogDomain;
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = iphoneos;
Expand Down Expand Up @@ -435,6 +438,8 @@
};
F0EB74E2AA0977D6CB2E3A56 /* Release */ = {
isa = XCBuildConfiguration;
baseConfigurationReferenceAnchor = 534E4B81FFFA3D0023139ACE /* Sources */;
baseConfigurationReferenceRelativePath = Version.xcconfig;
buildSettings = {
CLANG_ENABLE_OBJC_WEAK = NO;
CURRENT_PROJECT_VERSION = 1;
Expand All @@ -450,6 +455,7 @@
"@executable_path/Frameworks",
"@loader_path/Frameworks",
);
MARKETING_VERSION = 1.2;
PRODUCT_BUNDLE_IDENTIFIER = com.opfic.DevLog.DevLogDomain;
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = iphoneos;
Expand Down
1 change: 1 addition & 0 deletions Application/DevLogDomain/Sources/Version.xcconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
#include "../../Shared/Version.xcconfig"
6 changes: 6 additions & 0 deletions Application/DevLogInfra/DevLogInfra.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,8 @@
};
7569DA679CECDD9F8128BF95 /* Release */ = {
isa = XCBuildConfiguration;
baseConfigurationReferenceAnchor = 959D79D1263CC74E32B40D78 /* Sources */;
baseConfigurationReferenceRelativePath = Version.xcconfig;
buildSettings = {
CLANG_ENABLE_OBJC_WEAK = NO;
CURRENT_PROJECT_VERSION = 1;
Expand All @@ -316,6 +318,7 @@
"@executable_path/Frameworks",
"@loader_path/Frameworks",
);
MARKETING_VERSION = 1.2;
PRODUCT_BUNDLE_IDENTIFIER = com.opfic.DevLog.DevLogInfra;
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = iphoneos;
Expand Down Expand Up @@ -403,6 +406,8 @@
};
DD3059FD7C49E00F6F754331 /* Debug */ = {
isa = XCBuildConfiguration;
baseConfigurationReferenceAnchor = 959D79D1263CC74E32B40D78 /* Sources */;
baseConfigurationReferenceRelativePath = Version.xcconfig;
buildSettings = {
CLANG_ENABLE_OBJC_WEAK = NO;
CURRENT_PROJECT_VERSION = 1;
Expand All @@ -418,6 +423,7 @@
"@executable_path/Frameworks",
"@loader_path/Frameworks",
);
MARKETING_VERSION = 1.2;
PRODUCT_BUNDLE_IDENTIFIER = com.opfic.DevLog.DevLogInfra;
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = iphoneos;
Expand Down
1 change: 1 addition & 0 deletions Application/DevLogInfra/Sources/Version.xcconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
#include "../../Shared/Version.xcconfig"
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,8 @@
};
586E1D6B64BF31CC733055C9 /* Release */ = {
isa = XCBuildConfiguration;
baseConfigurationReferenceAnchor = 63CE47D539EE6F9653C99773 /* Sources */;
baseConfigurationReferenceRelativePath = Version.xcconfig;
buildSettings = {
CLANG_ENABLE_OBJC_WEAK = NO;
CURRENT_PROJECT_VERSION = 1;
Expand All @@ -366,6 +368,7 @@
"@executable_path/Frameworks",
"@loader_path/Frameworks",
);
MARKETING_VERSION = 1.2;
PRODUCT_BUNDLE_IDENTIFIER = com.opfic.DevLog.DevLogPersistence;
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = iphoneos;
Expand Down Expand Up @@ -457,6 +460,8 @@
};
D36B8CAC0F1A28A54A5C1BFA /* Debug */ = {
isa = XCBuildConfiguration;
baseConfigurationReferenceAnchor = 63CE47D539EE6F9653C99773 /* Sources */;
baseConfigurationReferenceRelativePath = Version.xcconfig;
buildSettings = {
CLANG_ENABLE_OBJC_WEAK = NO;
CURRENT_PROJECT_VERSION = 1;
Expand All @@ -472,6 +477,7 @@
"@executable_path/Frameworks",
"@loader_path/Frameworks",
);
MARKETING_VERSION = 1.2;
PRODUCT_BUNDLE_IDENTIFIER = com.opfic.DevLog.DevLogPersistence;
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = iphoneos;
Expand Down
1 change: 1 addition & 0 deletions Application/DevLogPersistence/Sources/Version.xcconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
#include "../../Shared/Version.xcconfig"
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,8 @@
};
3B6C7C7825EC72D04CACF6BF /* Release */ = {
isa = XCBuildConfiguration;
baseConfigurationReferenceAnchor = A4A427D518004ED78EB659DE /* Sources */;
baseConfigurationReferenceRelativePath = Version.xcconfig;
buildSettings = {
CLANG_ENABLE_OBJC_WEAK = NO;
CURRENT_PROJECT_VERSION = 1;
Expand All @@ -344,6 +346,7 @@
"@executable_path/Frameworks",
"@loader_path/Frameworks",
);
MARKETING_VERSION = 1.2;
PRODUCT_BUNDLE_IDENTIFIER = com.opfic.DevLog.DevLogPresentation;
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = iphoneos;
Expand All @@ -358,6 +361,8 @@
};
8DD7AD0C295CF0638E03F403 /* Debug */ = {
isa = XCBuildConfiguration;
baseConfigurationReferenceAnchor = A4A427D518004ED78EB659DE /* Sources */;
baseConfigurationReferenceRelativePath = Version.xcconfig;
buildSettings = {
CLANG_ENABLE_OBJC_WEAK = NO;
CURRENT_PROJECT_VERSION = 1;
Expand All @@ -373,6 +378,7 @@
"@executable_path/Frameworks",
"@loader_path/Frameworks",
);
MARKETING_VERSION = 1.2;
PRODUCT_BUNDLE_IDENTIFIER = com.opfic.DevLog.DevLogPresentation;
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = iphoneos;
Expand Down
1 change: 1 addition & 0 deletions Application/DevLogPresentation/Sources/Version.xcconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
#include "../../Shared/Version.xcconfig"
1 change: 1 addition & 0 deletions Application/Shared/Version.xcconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
MARKETING_VERSION = 1.2
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,8 @@
/* Begin XCBuildConfiguration section */
8E2FD158204AEBB5D6B1CAA7 /* Release */ = {
isa = XCBuildConfiguration;
baseConfigurationReferenceAnchor = B60F0C6B052E1EF8CC827AD9 /* Sources */;
baseConfigurationReferenceRelativePath = Version.xcconfig;
buildSettings = {
CLANG_ENABLE_OBJC_WEAK = NO;
CURRENT_PROJECT_VERSION = 1;
Expand All @@ -271,6 +273,7 @@
"@executable_path/Frameworks",
"@loader_path/Frameworks",
);
MARKETING_VERSION = 1.2;
PRODUCT_BUNDLE_IDENTIFIER = com.opfic.DevLog.DevLogWidgetCore;
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = iphoneos;
Expand Down Expand Up @@ -308,6 +311,8 @@
};
C5BA4998DAC2550DE98EA22B /* Debug */ = {
isa = XCBuildConfiguration;
baseConfigurationReferenceAnchor = B60F0C6B052E1EF8CC827AD9 /* Sources */;
baseConfigurationReferenceRelativePath = Version.xcconfig;
buildSettings = {
CLANG_ENABLE_OBJC_WEAK = NO;
CURRENT_PROJECT_VERSION = 1;
Expand All @@ -323,6 +328,7 @@
"@executable_path/Frameworks",
"@loader_path/Frameworks",
);
MARKETING_VERSION = 1.2;
PRODUCT_BUNDLE_IDENTIFIER = com.opfic.DevLog.DevLogWidgetCore;
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = iphoneos;
Expand Down
1 change: 1 addition & 0 deletions Widget/DevLogWidgetCore/Sources/Version.xcconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
#include "../../../Application/Shared/Version.xcconfig"