fix(parser): support host namespaces inside nested security contexts with validation precedence#56
Open
i-OmSharma wants to merge 1 commit into
Open
Conversation
…th validation precedence
|
First PR — welcome aboard! A few things to expect:
If you get stuck, reply here or jump to Discussions. We want this PR to land. |
Author
|
Hi @btwshivam, I have opened this PR to resolve the nested host namespace parsing issue cleanly. All automated CI pipelines, linter workflows, and cross-platform tests (macOS/Ubuntu) have passed successfully with 100% green status! 🔍 Quick Architectural Summary:
The diff is completely atomic (+78 lines) and contains 0 merge conflicts against main. Ready for your review and merge! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary of Changes
This PR addresses the false-negative parser issue where nested host namespace configurations (
hostNetwork,hostPID,hostIPC) under security boundaries likepodSecurityContextwere being silently ignored.pkg/parser/helm.go):applySecFieldsto scan and unpack nested scalar keys for all three host namespace flags.if out.HostNetwork == nil) to preserve standard Kubernetes priority semantics—ensuring workload-level explicit declarations safely override nested maps.pkg/parser/helm_test.go):host-namespace-flags-nested-under-podSecurityContextcase to verify that nested flags are no longer dropped and evaluate cleanly to true.workload-level-host-flags-take-precedencecase to lock in structural fallback rules.Closes #39
🧪 Testing Details
go test -v -race -count=1 ./pkg/parser/...