add helpers to dump max inflight io time for one disk and its disk driver#205
Open
biger410 wants to merge 9 commits intooracle-samples:mainfrom
Open
add helpers to dump max inflight io time for one disk and its disk driver#205biger410 wants to merge 9 commits intooracle-samples:mainfrom
biger410 wants to merge 9 commits intooracle-samples:mainfrom
Conversation
Pass "diskname" as nvme$X-$qtype, "X" is the controller ID and qtype is "admin", "connect" or "fabrics". Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com>
Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com>
Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com>
Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com>
Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com>
Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com>
Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com>
For scsi/nvme, it will dump the physical driver module name. For md, it will dump the raid driver. For dm, it will dump target driver. Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com>
Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com>
brenns10
approved these changes
Mar 20, 2026
Member
brenns10
left a comment
There was a problem hiding this comment.
This all looks pretty reasonable to me. One question on the NVME code but I'd defer to you on it.
More broadly - are the disk names the best way to detect what subsystem is used for the disk? Seems to me like struct gendisk has fops which might point to a specific operations struct, which seems like a more canonical way of detecting these things.
Again, I'd defer to your judgment there, so consider this approved if these aren't really valid concerns.
Comment on lines
+25
to
+31
| diskname = disk.disk_name.string_().decode() | ||
| if not diskname.startswith("nvme"): | ||
| return None | ||
|
|
||
| q = disk.queue | ||
| ns = Object(prog, "struct nvme_ns *", value=q.queuedata.value_()) | ||
| return ns.ctrl |
Member
There was a problem hiding this comment.
Is this the best way to get the nvme_ns? Compared to consulting disk->fops and disk->private_data?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two columns "DRIVER" and "Max Inflight time" are added.