Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
sonleoracle
force-pushed
the
feat-retry-policy
branch
from
23541fd to
4b92d53
Compare
paul-cayet
force-pushed
the
feat-retry-policy
branch
from
4b92d53 to
34b5950
Compare
paul-cayet
requested review from
cesarebernardis,
dhilloulinoracle,
jschweiz and
paul-cayet
and removed request for
jschweiz
|
Internal regression succeeded 🍏: Build ID #372 |
|
|
||
|
|
||
| * ``max_attempts``: maximum number of retries for a request that fails with a recoverable status. | ||
| Defaults to 2. |
There was a problem hiding this comment.
What do "Defaults to" mean in this scope? They are not optional and the configuration is supposed to be complete for now, so we should always include the values. I would remove these statements (they can still be the default values we set in pyagentspec).
| of the number of attempts. Defaults to 2.0. | ||
| * ``jitter``: type of backoff we want to do. Defaults to ``"full_and_equal_for_throttle"``. | ||
|
|
||
| * ``None``: ``t = min(min_wait * (backoff_factor ** attempts), max_wait)`` |
There was a problem hiding this comment.
Seems a bit weird that None does not coincide with any of the other options (or am I wrong?). Why don't we give a name to that option too?
|
|
||
| * **Retry policy for remote transports and agents:** | ||
|
|
||
| Added ``retry_policy`` support to components remote MCP transports, ``OciAgent``, |
There was a problem hiding this comment.
MCP transports
We don't I think, no? We say "MCP remote transports currently do not define a retry_policy attribute."
| * **Retry policy for remote transports and agents:** | ||
|
|
||
| Added ``retry_policy`` support to components remote MCP transports, ``OciAgent``, | ||
| and ``A2AAgent`` so SDK users can configure retries, backoff, and request timeouts |
There was a problem hiding this comment.
Also OciAgents and A2A don't have the new retry in the spec no? Please double check this changelog entry.
| pyyaml==6.0.3 | ||
| httpx==0.28.1 | ||
| urllib3==2.6.2 | ||
| urllib3==2.6.3 |
There was a problem hiding this comment.
Does it align with the BAs we have?
| # `retry_policy` was introduced in Agent Spec 26.2.0. | ||
| # For backwards compatibility, omit the field when not explicitly set | ||
| # (example 26.2.0 configs do not include `retry_policy: null`). | ||
| if agentspec_version < AgentSpecVersionEnum.v26_2_0 or self.retry_policy is None: |
There was a problem hiding this comment.
Config should be complete for now, don't exclude it if the version is >= 26.2.0
4 participants
This PR adds the RetryPolicy config object to Agent Spec so that users can configure networked components (LLMConfig, API Node, RemoteTool) how to retry when the request does not succeed.
closes #119