Open
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
sonleoracle
force-pushed
the
feat-state-snapshot-tracing
branch
3 times, most recently
from
3db80e9 to
60bae07
Compare
sonleoracle
requested review from
cesarebernardis,
dhilloulinoracle and
paul-cayet
Contributor
|
Internal regression succeeded 🍏: Build ID #373 |
dhilloulinoracle
approved these changes
Mar 18, 2026
sonleoracle
force-pushed
the
feat-state-snapshot-tracing
branch
2 times, most recently
from
563a2c5 to
05ceab0
Compare
Contributor
|
Internal regression succeeded 🍏: Build ID #382 |
sonleoracle
force-pushed
the
feat-state-snapshot-tracing
branch
from
05ceab0 to
38c1662
Compare
cesarebernardis
approved these changes
Mar 20, 2026
| StateSnapshotEmitted(conversation_id="conversation-123", **kwargs) | ||
|
|
||
|
|
||
| def test_state_snapshot_emitted_accepts_realistic_wayflow_resumable_payload() -> None: |
Member
There was a problem hiding this comment.
Nit: I would not put anything runtime-specific in this folder, even if it's not really using the runtime. I think you can just avoid mentioning wayflow and use a generic runtime.
paul-cayet
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes three related tracing improvements:
The first change introduces the StateSnapshotEmitted event model needed for runtime state snapshot emission. The second fixes an existing issue in exception tracing so traceback content is formatted and asserted correctly. The third is a small test cleanup to make the async tracing tests more idiomatic and easier to maintain.