Merged
Conversation
…reset on import, DB alias sync, testbed 503 crash - ollama.py: detect embedding models by 'embed' in name (catches qwen3-embedding, mxbai-embed-large which report non-embed families) - litellm_utils.py: strip ':latest' tag when matching Ollama models so a vector store saved as 'ollama/model:latest' resolves correctly - settings.py (import): preserve usable=True for existing DB configs when connection-relevant fields are unchanged; only reset on actual credential changes - databases.py: sync client_settings.database.alias on every page load and on "no changes" save-click so the active DB is not lost after server restart - testbed.py: return [] on 503 from /testbed/testsets instead of crashing when CORE DB is unavailable - obaas.yaml + settings.py: fix YAML ParserError when sys_prompt contains double quotes or newlines by using yaml.dump(default_style='"') and removing redundant outer quotes from the template placeholder Signed-off-by: Vili Tajnic <vili.tajnic@oracle.com>
Previously generate_testset_endpoint ran the full expensive LLM/Giskard PDF processing before calling _require_core_pool() inside _store_generated_testset, wasting minutes of work before returning a 503. Move the pool check to the top of the endpoint so it fails immediately. Pass the resolved pool into _store_generated_testset to avoid a redundant second lookup. Add test asserting _process_pdf_file is never called when the pool is absent. Signed-off-by: Vili Tajnic <vili.tajnic@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
ViliTajnic
approved these changes
Apr 14, 2026
Contributor
ViliTajnic
left a comment
ViliTajnic
left a comment
There was a problem hiding this comment.
Checked all bug fixes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.