Skip to content

chore(deps-dev): update mypy requirement from >=1.19.1,<1.20 to >=2.0.0,<3.0.0 and fix and adjust configuration and fix code according to the newly uncovered type errors#1437

Draft
jenstroeger wants to merge 2 commits into
oracle:mainfrom
jenstroeger:improve-type-checking

Conversation

@jenstroeger

Copy link
Copy Markdown
Contributor

Summary

The current version of mypy is v2.3.0 although PR #1396 stalls at v1.20.2 — there’s no Dependabot for v2? But even so, that PR fails because of how mypy is configured and how it’s used by pre-commit. Related issue discussions are python/mypy#13916 and python/mypy#21769.

This PR is in Draft so we can discuss and fix a few type issues.

Description of changes

  1. Update mypy to its most recent version v2.3.0.
  2. Fix the configuration as per Using mypy via pre-commit python/mypy#13916.
  3. Fix the type issues discovered by above changes 1. and 2.

Related issues

n/a

Checklist

  • I have reviewed the contribution guide.
  • My PR title and commits follow the Conventional Commits convention.
  • My commits include the "Signed-off-by" line.
  • I have signed my commits following the instructions provided by GitHub. Note that we run GitHub's commit verification tool to check the commit signatures. A green verified label should appear next to all of your commits on GitHub.
  • I have updated the relevant documentation, if applicable.
  • I have tested my changes and verified they work as expected.

@jenstroeger
jenstroeger requested a review from behnazh-w as a code owner July 24, 2026 17:58
@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 24, 2026
@jenstroeger
jenstroeger marked this pull request as draft July 24, 2026 17:58
….0,<3.0.0 and fix and adjust configuration and fix code according to the newly uncovered type errors

Signed-off-by: Jens Troeger <jens.troeger@light-speed.de>
@jenstroeger
jenstroeger force-pushed the improve-type-checking branch from 7231717 to 63973da Compare July 24, 2026 17:59
@jenstroeger

Copy link
Copy Markdown
Contributor Author

Thanks @behnazh-w for running CI: please take a look at the failing type checks here. Shall I go ahead and address these issues or do you want to do that yourself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant