Honor signDisplay in the native number converter#105
Open
jasperan wants to merge 2 commits intooracle:masterfrom
Open
Honor signDisplay in the native number converter#105jasperan wants to merge 2 commits intooracle:masterfrom
jasperan wants to merge 2 commits intooracle:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #70 by threading
signDisplaythrough the native number converter runtime and public option types.Problem
oj.IntlNumberConverterignoredsignDisplay: 'always'even though nativeIntl.NumberFormatdisplayed the expected+sign for positive and zero values.Reproduction
Format positive, zero, and negative values with a JET number converter configured with
signDisplay: 'always', then compare the output to nativeIntl.NumberFormat.Before this patch, JET returned
"5"and"0"where native formatting returned"+5"and"+0".Changes
signDisplaythrough the resolved converter option shapesignDisplayinto the native formatter optionssignDisplayin the public TypeScript option typesVerification
Intl.NumberFormatfor positive, zero, and negative valuesnpm pack --dry-runScope / Caveats
signDisplaybehavior in the native number converter path