Add native ESM entry points and runtime shims#106
Open
jasperan wants to merge 8 commits intooracle:masterfrom
Open
Add native ESM entry points and runtime shims#106jasperan wants to merge 8 commits intooracle:masterfrom
jasperan wants to merge 8 commits intooracle:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #93 by making the shipped
debug_esmruntime self-contained enough for native ESM loading and by exposing representative package-level ESM subpath imports.Problem
Oracle JET already shipped a
debug_esmtree, but it was not directly usable under native ESM because:ojs/*specifiers@oracle/oraclejet/ojkeysetwere not exportedwindowunconditionallyChanges
debug_esmimports from bareojs/*specifiers to relative./*.jsimportsdist/js/libs/oj/debug_esm/package.jsonwithtype: moduleexportsso representative installed-package ESM subpath imports resolve cleanlyojalias references in the older converter stack so number/date converters and date validators import cleanly under ESMVerification
debug_esmimportsnpm pack --dry-runScope / Caveats