feat: add FileStore annotation constants#352
feat: add FileStore annotation constants#352wangxiaoxuan273 wants to merge 1 commit intooras-project:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #352 +/- ##
=======================================
Coverage 91.76% 91.76%
=======================================
Files 64 64
Lines 2755 2755
Branches 364 364
=======================================
Hits 2528 2528
Misses 138 138
Partials 89 89 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR introduces FileStore-specific annotation key constants as part of the File Store implementation. It adds two annotation constants that match the oras-go v2 implementation, maintaining compatibility with the upstream Go library.
Changes:
- Adds
FileStoreAnnotationsclass with two annotation key constants for digest and unpack indicators - Includes comprehensive unit tests validating the constant values
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/OrasProject.Oras/Content/File/Annotations.cs | Defines FileStore annotation key constants for digest tracking and unpack indication |
| tests/OrasProject.Oras.Tests/Content/File/AnnotationsTest.cs | Unit tests validating the annotation constant values |
Adds FileStore-specific annotation key constants for digest and unpack indicators. Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
676eeba to
8d0c283
Compare
|
Caution This review was generated by Copilot using Claude Opus 4.6, mimicking the review style of shizhMSFT. This is not the real shizhMSFT. Review of PR #352 Verified constants match oras-go ( 1. Legacy These annotations use the 2.
Otherwise SGTM — simple, correct, well-tested constants. |
|
@wangxiaoxuan273 can you follow up on the previous AI comment and address them if you feel they are relevant? |
| /// digest of the uncompressed content. | ||
| /// </summary> | ||
| public const string AnnotationDigest = | ||
| "io.deis.oras.content.digest"; |
There was a problem hiding this comment.
very minor nit: in PR 351 these sort of declarations are on a single line but these are on 2 lines. Is there a standard line length?
What this PR does / why we need it
Adds FileStore-specific annotation key constants for digest and unpack indicators used by the File Store implementation.
FileStoreAnnotations.AnnotationDigest— key for the digest of uncompressed contentFileStoreAnnotations.AnnotationUnpack— key for indication of unpackingIncludes a test file that validates all constant values.
Which issue(s) this PR resolves / fixes
Part of the File Store implementation split (issue 2 of 10).
Related: #328, #37
Please check the following list