Skip to content

fix(orcide): resolve stale void references and type error from PR #18 merge#22

Merged
danialsamiei merged 1 commit intomainfrom
claude/fix-build-isWeb-qNsCI
Feb 21, 2026
Merged

fix(orcide): resolve stale void references and type error from PR #18 merge#22
danialsamiei merged 1 commit intomainfrom
claude/fix-build-isWeb-qNsCI

Conversation

@danialsamiei
Copy link
Copy Markdown
Collaborator

… merge

Update imports and identifiers that PR #18 introduced using old void naming, which conflict with the orcide rename from PR #19:

  • app.ts: voidUpdateService → orcideUpdateService, voidUpdateMainService → orcideUpdateMainService, voidSCMMainService → orcideSCMMainService, voidSCMTypes → orcideSCMTypes, class names VoidMainUpdateService → OrcideMainUpdateService, VoidSCMService → OrcideSCMService
  • editorGroupWatermark.ts: VOID_CTRL_K/L_ACTION_ID → ORCIDE_CTRL_K/L_ACTION_ID
  • fileActions.contribution.ts: void/browser/voidSettingsPane → orcide/browser/orcideSettingsPane, VOID_OPEN_SETTINGS_ACTION_ID → ORCIDE_OPEN_SETTINGS_ACTION_ID
  • orcideSelectionHelperWidget.ts: fix IDisposable|null type error by using local variable instead of nullable field

https://claude.ai/code/session_01UgRm1eNr4jVDQ4tVK2LXoR

…merge

Update imports and identifiers that PR #18 introduced using old void
naming, which conflict with the orcide rename from PR #19:
- app.ts: voidUpdateService → orcideUpdateService, voidUpdateMainService
  → orcideUpdateMainService, voidSCMMainService → orcideSCMMainService,
  voidSCMTypes → orcideSCMTypes, class names VoidMainUpdateService →
  OrcideMainUpdateService, VoidSCMService → OrcideSCMService
- editorGroupWatermark.ts: VOID_CTRL_K/L_ACTION_ID → ORCIDE_CTRL_K/L_ACTION_ID
- fileActions.contribution.ts: void/browser/voidSettingsPane →
  orcide/browser/orcideSettingsPane, VOID_OPEN_SETTINGS_ACTION_ID →
  ORCIDE_OPEN_SETTINGS_ACTION_ID
- orcideSelectionHelperWidget.ts: fix IDisposable|null type error by
  using local variable instead of nullable field

https://claude.ai/code/session_01UgRm1eNr4jVDQ4tVK2LXoR
@danialsamiei danialsamiei merged commit fc7a9cb into main Feb 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants