Skip to content

feat(builder): improv default value for not null column at alter table add column comand #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jconzatti merged 1 commit into from
Feb 24, 2026
Merged

feat(builder): improv default value for not null column at alter table add column comand #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions dialects/postgresql/builder_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,26 @@ func TestAlterTableAddColumn(t *testing.T) {
expectedSQL := "ALTER TABLE \"user\" ADD COLUMN \"updated_at\" TIMESTAMP(6);"
returnedSQL := sqlBuilder.AlterTableAddColumn(userTableName, updatedAtColumn)
testutils.AssertEqualWithLabel(t, expectedSQL, returnedSQL, "SQLBuilder.AlterTableAddColumn")

createdAtColumn := testutils.FakeCreatedAtColumn(t)
expectedSQL = "ALTER TABLE \"user\" ADD COLUMN \"created_at\" TIMESTAMPZ(6) NOT NULL DEFAULT CURRENT_TIMESTAMP;"
returnedSQL = sqlBuilder.AlterTableAddColumn(userTableName, createdAtColumn)
testutils.AssertEqualWithLabel(t, expectedSQL, returnedSQL, "SQLBuilder.AlterTableAddColumn")

priceColumn := testutils.FakePriceColumn(t)
expectedSQL = "ALTER TABLE \"user\" ADD COLUMN \"price\" NUMERIC(17,2) NOT NULL DEFAULT 0.0;"
returnedSQL = sqlBuilder.AlterTableAddColumn(userTableName, priceColumn)
testutils.AssertEqualWithLabel(t, expectedSQL, returnedSQL, "SQLBuilder.AlterTableAddColumn")

scoreColumn := testutils.FakeScoreColumn(t)
expectedSQL = "ALTER TABLE \"user\" ADD COLUMN \"score\" BIGINT NOT NULL DEFAULT 0;"
returnedSQL = sqlBuilder.AlterTableAddColumn(userTableName, scoreColumn)
testutils.AssertEqualWithLabel(t, expectedSQL, returnedSQL, "SQLBuilder.AlterTableAddColumn")

nameColumn := testutils.FakeNameColumn(t)
expectedSQL = "ALTER TABLE \"user\" ADD COLUMN \"name\" VARCHAR(50) NOT NULL DEFAULT '';"
returnedSQL = sqlBuilder.AlterTableAddColumn(userTableName, nameColumn)
testutils.AssertEqualWithLabel(t, expectedSQL, returnedSQL, "SQLBuilder.AlterTableAddColumn")
}

func TestAlterTableDropColumn(t *testing.T) {
Expand Down
20 changes: 20 additions & 0 deletions dialects/sqlite/builder_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,26 @@ func TestAlterTableAddColumn(t *testing.T) {
expectedSQL := "ALTER TABLE \"user\" ADD COLUMN \"updated_at\" DATETIME;"
returnedSQL := sqlBuilder.AlterTableAddColumn(userTableName, updatedAtColumn)
testutils.AssertEqualWithLabel(t, expectedSQL, returnedSQL, "SQLBuilder.AlterTableAddColumn")

createdAtColumn := testutils.FakeCreatedAtColumn(t)
expectedSQL = "ALTER TABLE \"user\" ADD COLUMN \"created_at\" DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP;"
returnedSQL = sqlBuilder.AlterTableAddColumn(userTableName, createdAtColumn)
testutils.AssertEqualWithLabel(t, expectedSQL, returnedSQL, "SQLBuilder.AlterTableAddColumn")

priceColumn := testutils.FakePriceColumn(t)
expectedSQL = "ALTER TABLE \"user\" ADD COLUMN \"price\" REAL NOT NULL DEFAULT 0.0;"
returnedSQL = sqlBuilder.AlterTableAddColumn(userTableName, priceColumn)
testutils.AssertEqualWithLabel(t, expectedSQL, returnedSQL, "SQLBuilder.AlterTableAddColumn")

scoreColumn := testutils.FakeScoreColumn(t)
expectedSQL = "ALTER TABLE \"user\" ADD COLUMN \"score\" INTEGER NOT NULL DEFAULT 0;"
returnedSQL = sqlBuilder.AlterTableAddColumn(userTableName, scoreColumn)
testutils.AssertEqualWithLabel(t, expectedSQL, returnedSQL, "SQLBuilder.AlterTableAddColumn")

nameColumn := testutils.FakeNameColumn(t)
expectedSQL = "ALTER TABLE \"user\" ADD COLUMN \"name\" TEXT NOT NULL DEFAULT '';"
returnedSQL = sqlBuilder.AlterTableAddColumn(userTableName, nameColumn)
testutils.AssertEqualWithLabel(t, expectedSQL, returnedSQL, "SQLBuilder.AlterTableAddColumn")
}

func TestAlterTableDropColumn(t *testing.T) {
Expand Down
20 changes: 20 additions & 0 deletions dialects/sqlserver/builder_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,26 @@ func TestAlterTableAddColumn(t *testing.T) {
expectedSQL := "ALTER TABLE [user] ADD COLUMN [updated_at] DATETIME2(6);"
returnedSQL := sqlBuilder.AlterTableAddColumn(userTableName, updatedAtColumn)
testutils.AssertEqualWithLabel(t, expectedSQL, returnedSQL, "SQLBuilder.AlterTableAddColumn")

createdAtColumn := testutils.FakeCreatedAtColumn(t)
expectedSQL = "ALTER TABLE [user] ADD COLUMN [created_at] DATETIMEOFFSET(6) NOT NULL DEFAULT CURRENT_TIMESTAMP;"
returnedSQL = sqlBuilder.AlterTableAddColumn(userTableName, createdAtColumn)
testutils.AssertEqualWithLabel(t, expectedSQL, returnedSQL, "SQLBuilder.AlterTableAddColumn")

priceColumn := testutils.FakePriceColumn(t)
expectedSQL = "ALTER TABLE [user] ADD COLUMN [price] MONEY NOT NULL DEFAULT 0.0;"
returnedSQL = sqlBuilder.AlterTableAddColumn(userTableName, priceColumn)
testutils.AssertEqualWithLabel(t, expectedSQL, returnedSQL, "SQLBuilder.AlterTableAddColumn")

scoreColumn := testutils.FakeScoreColumn(t)
expectedSQL = "ALTER TABLE [user] ADD COLUMN [score] BIGINT NOT NULL DEFAULT 0;"
returnedSQL = sqlBuilder.AlterTableAddColumn(userTableName, scoreColumn)
testutils.AssertEqualWithLabel(t, expectedSQL, returnedSQL, "SQLBuilder.AlterTableAddColumn")

nameColumn := testutils.FakeNameColumn(t)
expectedSQL = "ALTER TABLE [user] ADD COLUMN [name] VARCHAR(50) NOT NULL DEFAULT '';"
returnedSQL = sqlBuilder.AlterTableAddColumn(userTableName, nameColumn)
testutils.AssertEqualWithLabel(t, expectedSQL, returnedSQL, "SQLBuilder.AlterTableAddColumn")
}

func TestAlterTableDropColumn(t *testing.T) {
Expand Down
16 changes: 15 additions & 1 deletion internal/builder_generic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,21 @@ func (sb *genericSQLBuilder) DropTable(table string) string {
}

func (sb *genericSQLBuilder) AlterTableAddColumn(table string, column schema.Column) string {
return fmt.Sprintf("ALTER TABLE %s ADD COLUMN %s;", sb.QuoteIdentifier(table), sb.columnDefinition(column))
defaultValue := ""
if column.NotNull() {
defaultValue = " DEFAULT "
switch column.Type() {
case schema.Boolean, schema.Integer:
defaultValue += "0"
case schema.DateTime, schema.DateTimeOffSet:
defaultValue += "CURRENT_TIMESTAMP"
case schema.Monetary, schema.Decimal:
defaultValue += "0.0"
default:
defaultValue += "''"
}
}
return fmt.Sprintf("ALTER TABLE %s ADD COLUMN %s%s;", sb.QuoteIdentifier(table), sb.columnDefinition(column), defaultValue)
}

func (sb *genericSQLBuilder) AlterTableDropColumn(table, column string) string {
Expand Down
21 changes: 21 additions & 0 deletions internal/builder_generic_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,31 @@ func TestAlterTableAddColumn(t *testing.T) {
sqlBuilder := internal.NewGenericSQLBuilder(nil, nil, nil)

userTableName := testutils.FakeUserTableName(t)

updatedAtColumn := testutils.FakeUpdatedAtColumn(t)
expectedSQL := "ALTER TABLE \"user\" ADD COLUMN \"updated_at\" <<TYPE_3>>;"
returnedSQL := sqlBuilder.AlterTableAddColumn(userTableName, updatedAtColumn)
testutils.AssertEqualWithLabel(t, expectedSQL, returnedSQL, "SQLBuilder.AlterTableAddColumn")

createdAtColumn := testutils.FakeCreatedAtColumn(t)
expectedSQL = "ALTER TABLE \"user\" ADD COLUMN \"created_at\" <<TYPE_7>> DEFAULT CURRENT_TIMESTAMP;"
returnedSQL = sqlBuilder.AlterTableAddColumn(userTableName, createdAtColumn)
testutils.AssertEqualWithLabel(t, expectedSQL, returnedSQL, "SQLBuilder.AlterTableAddColumn")

priceColumn := testutils.FakePriceColumn(t)
expectedSQL = "ALTER TABLE \"user\" ADD COLUMN \"price\" <<TYPE_2>> DEFAULT 0.0;"
returnedSQL = sqlBuilder.AlterTableAddColumn(userTableName, priceColumn)
testutils.AssertEqualWithLabel(t, expectedSQL, returnedSQL, "SQLBuilder.AlterTableAddColumn")

scoreColumn := testutils.FakeScoreColumn(t)
expectedSQL = "ALTER TABLE \"user\" ADD COLUMN \"score\" <<TYPE_0>> DEFAULT 0;"
returnedSQL = sqlBuilder.AlterTableAddColumn(userTableName, scoreColumn)
testutils.AssertEqualWithLabel(t, expectedSQL, returnedSQL, "SQLBuilder.AlterTableAddColumn")

nameColumn := testutils.FakeNameColumn(t)
expectedSQL = "ALTER TABLE \"user\" ADD COLUMN \"name\" <<TYPE_1>> DEFAULT '';"
returnedSQL = sqlBuilder.AlterTableAddColumn(userTableName, nameColumn)
testutils.AssertEqualWithLabel(t, expectedSQL, returnedSQL, "SQLBuilder.AlterTableAddColumn")
}

func TestAlterTableDropColumn(t *testing.T) {
Expand Down
41 changes: 41 additions & 0 deletions internal/testutils/fake.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,47 @@ func FakeUpdatedAtColumn(t *testing.T) schema.Column {
return updatedAtColumn
}

func FakeCreatedAtColumn(t *testing.T) schema.Column {
return schema.NewColumn(schema.NewColumnParams{
Name: "created_at",
Type: schema.DateTimeOffSet,
PrimaryKey: false,
NotNull: true,
AutoIncrement: false,
})
}

func FakeScoreColumn(t *testing.T) schema.Column {
return schema.NewColumn(schema.NewColumnParams{
Name: "score",
Type: schema.Integer,
PrimaryKey: false,
NotNull: true,
AutoIncrement: false,
})
}

func FakePriceColumn(t *testing.T) schema.Column {
return schema.NewColumn(schema.NewColumnParams{
Name: "price",
Type: schema.Monetary,
PrimaryKey: false,
NotNull: true,
AutoIncrement: false,
})
}

func FakeNameColumn(t *testing.T) schema.Column {
return schema.NewColumn(schema.NewColumnParams{
Name: "name",
Type: schema.Varchar,
Size: 50,
PrimaryKey: false,
NotNull: true,
AutoIncrement: false,
})
}

func FakeUpdatedAtColumnName(t *testing.T) string {
return "updated_at"
}
Expand Down