Skip to content

fix(schema): default timestamp #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jconzatti merged 1 commit into from
Feb 24, 2026
Merged

fix(schema): default timestamp #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions dialects/postgresql/builder_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@ func TestAlterTableAddColumn(t *testing.T) {
returnedSQL = sqlBuilder.AlterTableAddColumn(userTableName, createdAtColumn)
testutils.AssertEqualWithLabel(t, expectedSQL, returnedSQL, "SQLBuilder.AlterTableAddColumn")

activatedAtColumn := testutils.FakeActivatedAtColumn(t)
expectedSQL = "ALTER TABLE \"user\" ADD COLUMN \"activated_at\" TIMESTAMP(6) NOT NULL DEFAULT '1900-01-01 00:00:00.000000';"
returnedSQL = sqlBuilder.AlterTableAddColumn(userTableName, activatedAtColumn)
testutils.AssertEqualWithLabel(t, expectedSQL, returnedSQL, "SQLBuilder.AlterTableAddColumn")

priceColumn := testutils.FakePriceColumn(t)
expectedSQL = "ALTER TABLE \"user\" ADD COLUMN \"price\" NUMERIC(17,2) NOT NULL DEFAULT 0.0;"
returnedSQL = sqlBuilder.AlterTableAddColumn(userTableName, priceColumn)
Expand Down
5 changes: 5 additions & 0 deletions dialects/sqlite/builder_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@ func TestAlterTableAddColumn(t *testing.T) {
returnedSQL = sqlBuilder.AlterTableAddColumn(userTableName, createdAtColumn)
testutils.AssertEqualWithLabel(t, expectedSQL, returnedSQL, "SQLBuilder.AlterTableAddColumn")

activatedAtColumn := testutils.FakeActivatedAtColumn(t)
expectedSQL = "ALTER TABLE \"user\" ADD COLUMN \"activated_at\" DATETIME NOT NULL DEFAULT '1900-01-01 00:00:00.000000';"
returnedSQL = sqlBuilder.AlterTableAddColumn(userTableName, activatedAtColumn)
testutils.AssertEqualWithLabel(t, expectedSQL, returnedSQL, "SQLBuilder.AlterTableAddColumn")

priceColumn := testutils.FakePriceColumn(t)
expectedSQL = "ALTER TABLE \"user\" ADD COLUMN \"price\" REAL NOT NULL DEFAULT 0.0;"
returnedSQL = sqlBuilder.AlterTableAddColumn(userTableName, priceColumn)
Expand Down
5 changes: 5 additions & 0 deletions dialects/sqlserver/builder_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@ func TestAlterTableAddColumn(t *testing.T) {
returnedSQL = sqlBuilder.AlterTableAddColumn(userTableName, createdAtColumn)
testutils.AssertEqualWithLabel(t, expectedSQL, returnedSQL, "SQLBuilder.AlterTableAddColumn")

activatedAtColumn := testutils.FakeActivatedAtColumn(t)
expectedSQL = "ALTER TABLE [user] ADD COLUMN [activated_at] DATETIME2(6) NOT NULL DEFAULT '1900-01-01 00:00:00.000000';"
returnedSQL = sqlBuilder.AlterTableAddColumn(userTableName, activatedAtColumn)
testutils.AssertEqualWithLabel(t, expectedSQL, returnedSQL, "SQLBuilder.AlterTableAddColumn")

priceColumn := testutils.FakePriceColumn(t)
expectedSQL = "ALTER TABLE [user] ADD COLUMN [price] MONEY NOT NULL DEFAULT 0.0;"
returnedSQL = sqlBuilder.AlterTableAddColumn(userTableName, priceColumn)
Expand Down
6 changes: 4 additions & 2 deletions internal/builder_generic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,12 @@ func (sb *genericSQLBuilder) AlterTableAddColumn(table string, column schema.Col
switch column.Type() {
case schema.Boolean, schema.Integer:
defaultValue += "0"
case schema.DateTime, schema.DateTimeOffSet:
defaultValue += "'1900-01-01 00:00:00.000000 +00:00'"
case schema.DateTime:
defaultValue += "'1900-01-01 00:00:00.000000'"
case schema.Monetary, schema.Decimal:
defaultValue += "0.0"
case schema.DateTimeOffSet:
defaultValue += "'1900-01-01 00:00:00.000000 +00:00'"
default:
defaultValue += "''"
}
Expand Down
5 changes: 5 additions & 0 deletions internal/builder_generic_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ func TestAlterTableAddColumn(t *testing.T) {
returnedSQL = sqlBuilder.AlterTableAddColumn(userTableName, createdAtColumn)
testutils.AssertEqualWithLabel(t, expectedSQL, returnedSQL, "SQLBuilder.AlterTableAddColumn")

activatedAtColumn := testutils.FakeActivatedAtColumn(t)
expectedSQL = "ALTER TABLE \"user\" ADD COLUMN \"activated_at\" <<TYPE_3>> DEFAULT '1900-01-01 00:00:00.000000';"
returnedSQL = sqlBuilder.AlterTableAddColumn(userTableName, activatedAtColumn)
testutils.AssertEqualWithLabel(t, expectedSQL, returnedSQL, "SQLBuilder.AlterTableAddColumn")

priceColumn := testutils.FakePriceColumn(t)
expectedSQL = "ALTER TABLE \"user\" ADD COLUMN \"price\" <<TYPE_2>> DEFAULT 0.0;"
returnedSQL = sqlBuilder.AlterTableAddColumn(userTableName, priceColumn)
Expand Down
10 changes: 10 additions & 0 deletions internal/testutils/fake.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,16 @@ func FakeCreatedAtColumn(t *testing.T) schema.Column {
})
}

func FakeActivatedAtColumn(t *testing.T) schema.Column {
return schema.NewColumn(schema.NewColumnParams{
Name: "activated_at",
Type: schema.DateTime,
PrimaryKey: false,
NotNull: true,
AutoIncrement: false,
})
}

func FakeScoreColumn(t *testing.T) schema.Column {
return schema.NewColumn(schema.NewColumnParams{
Name: "score",
Expand Down