Skip to content

feat(major): Make NaN signalling (trap on use) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hassila merged 5 commits into from
Mar 27, 2026

test: add tests for isFinite, sign, leastFiniteMagnitude, and signifi…

06630d2
Select commit
Loading
Failed to load commit list.
Merged

feat(major): Make NaN signalling (trap on use) #2

test: add tests for isFinite, sign, leastFiniteMagnitude, and signifi…
06630d2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 27, 2026 in 0s

98.62% (+0.83%) compared to 52bc71f

View this Pull Request on Codecov

98.62% (+0.83%) compared to 52bc71f

Details

Codecov Report

❌ Patch coverage is 98.18182% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.62%. Comparing base (52bc71f) to head (06630d2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/FixedPointDecimal/FixedPointDecimal.swift 70.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #2      +/-   ##
==========================================
+ Coverage   97.79%   98.62%   +0.83%     
==========================================
  Files          28       28              
  Lines        3795     3840      +45     
==========================================
+ Hits         3711     3787      +76     
+ Misses         84       53      -31
Files with missing lines Coverage Δ
...xedPointDecimal/FixedPointDecimal+Arithmetic.swift 100.00% <100.00%> (ø)
.../FixedPointDecimal/FixedPointDecimal+Numeric.swift 100.00% <100.00%> (ø)
...FixedPointDecimal/FixedPointDecimal+Overflow.swift 100.00% <100.00%> (ø)
...FixedPointDecimal/FixedPointDecimal+Rounding.swift 97.06% <100.00%> (ø)
.../FixedPointDecimal/FixedPointDecimal+SwiftUI.swift 90.91% <ø> (ø)
Tests/FixedPointDecimalTests/ArithmeticTests.swift 100.00% <100.00%> (ø)
Tests/FixedPointDecimalTests/BasicTests.swift 100.00% <100.00%> (ø)
Tests/FixedPointDecimalTests/ConversionTests.swift 100.00% <100.00%> (ø)
Tests/FixedPointDecimalTests/EdgeCaseTests.swift 100.00% <100.00%> (ø)
Tests/FixedPointDecimalTests/OverflowTests.swift 100.00% <100.00%> (ø)
... and 5 more

... and 2 files with indirect coverage changes

Files with missing lines Coverage Δ
...xedPointDecimal/FixedPointDecimal+Arithmetic.swift 100.00% <100.00%> (ø)
.../FixedPointDecimal/FixedPointDecimal+Numeric.swift 100.00% <100.00%> (ø)
...FixedPointDecimal/FixedPointDecimal+Overflow.swift 100.00% <100.00%> (ø)
...FixedPointDecimal/FixedPointDecimal+Rounding.swift 97.06% <100.00%> (ø)
.../FixedPointDecimal/FixedPointDecimal+SwiftUI.swift 90.91% <ø> (ø)
Tests/FixedPointDecimalTests/ArithmeticTests.swift 100.00% <100.00%> (ø)
Tests/FixedPointDecimalTests/BasicTests.swift 100.00% <100.00%> (ø)
Tests/FixedPointDecimalTests/ConversionTests.swift 100.00% <100.00%> (ø)
Tests/FixedPointDecimalTests/EdgeCaseTests.swift 100.00% <100.00%> (ø)
Tests/FixedPointDecimalTests/OverflowTests.swift 100.00% <100.00%> (ø)
... and 5 more

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f33510e...06630d2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov