feat: ✨ [NEW FEATURE] Creation of specific schemas for each team by vqlion · Pull Request #519 · org-SCAN/website

vqlion · 2025-01-17T14:00:05Z

Original issue description

Original issue description @lduf (transferred to discussion https://github.com//discussions/514)

Description:

This feature introduces the ability to dynamically create specific database schemas for individual teams. Each team will have its own schema, including custom tables such as fields, items, and links. The process will rely on Artisan commands to manage schema creation and migration execution, ensuring flexibility and modularity in the system. Tests will validate all functionalities to ensure a seamless experience.

Tasks to Perform:

Artisan Command to Generate Specific Schemas:
- Implement an Artisan command:
```
php artisan make:schema TEAM_ID
```
- This command must:
  - Verify if a schema for TEAM_ID already exists.
  - Create a new schema in the database if it does not exist.
Organize Schema-Specific Migrations:
- Establish a directory structure for migrations:
  - /database/migrations/global: Contains global migrations.
  - /database/migrations/teams/TEAM_ID: Contains migrations specific to a team.
Artisan Command to Copy and Execute Base Table Migrations:
- Implement an Artisan command:
```
php artisan migration:copy TABLE_NAME SCHEMA
```
- This command must:
  - Copy all required global migration files into the directory teams/TEAM_ID.
  - Execute the copied migrations in the specified schema.
Handle Global Migration Files:
- Approach: Direct Copy of Global Files
  - Identify all global migrations associated with a table and copy them into the team-specific schema directory.
  - Retain the complete history of table changes.
Schema Migration Execution:
- Execute all migrations in a specified schema using an Artisan command.
Unit and Functional Testing:
- Develop tests to validate the following functionalities:
  - Creating a specific schema.
  - Executing migrations within a specific schema.
  - Verifying the creation of the necessary tables.
- Test cases:
  - A team with an existing schema.
  - A team requiring multiple global migration files for a single table.

closes #517

- add command to create a schema for a specific team - add schema model issue: #517

- add command to migrate a specific schema from a team - can provide a custom migration path for teams specific migrations issue: #517

the create schema command also creates a migration folder for the team issue: #517

- test creating a new custom schema for a team - test migrate to a custom schema issue: #517

lduf · 2025-01-22T14:00:03Z

+        $schema->openDatabaseConnection();
+        $path = $this->option('path') ?? config('database.migration_path');
+
+        $this->call('migrate', ['--database' => $dbName, '--path' => $path]);


No error handling ?

(open question)

I think it's unlikely that an error occurs at that point, but I guess handling it couldn't hurt and it's extra safe 👍 (ace6224)

add error handling to migrate command call issue: #517

sonarqubecloud · 2025-01-31T10:31:01Z

Quality Gate passed

Issues
0 New issues
4 Accepted issues

Measures
0 Security Hotspots
70.7% Coverage on New Code
0.1% Duplication on New Code

See analysis details on SonarQube Cloud

…n_of_specific_schemas_for_each_team

sonarqubecloud · 2025-03-10T21:35:25Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copilot

Pull Request Overview

This PR implements a new feature for creating team-specific database schemas in a Laravel application. The system allows each team to have its own isolated database schema with custom tables, managed through Artisan commands.

Introduces Artisan commands for schema creation (make:schema) and migration (migrate:custom)
Creates a Schema model to track team-specific database schemas
Implements comprehensive test coverage for schema operations

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`src/tests/Feature/CustomSchemaTest.php`	Comprehensive test suite covering schema creation, migration, and error handling scenarios
`src/database/migrations/2025_01_15_143802_create_schemas_table.php`	Database migration to create the schemas tracking table
`src/app/Models/Schema.php`	Model for managing schema records with database connection utilities
`src/app/Console/Commands/MigrateCustomSchemaCommand.php`	Artisan command to execute migrations on team-specific schemas
`src/app/Console/Commands/MakeSchemaCommand.php`	Artisan command to create new team schemas and migration directories

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-13T11:12:06Z

+use Illuminate\Database\Eloquent\Factories\HasFactory;
+use Illuminate\Database\Eloquent\Model;
+use Illuminate\Database\Eloquent\Relations\BelongsTo;
+Use Illuminate\Database\Eloquent\SoftDeletes;


Corrected 'Use' to 'use' for proper PHP namespace import syntax.

Suggested change

Use Illuminate\Database\Eloquent\SoftDeletes;

use Illuminate\Database\Eloquent\SoftDeletes;

Copilot · 2025-10-13T11:12:07Z

+                $schema['name'] = $dbName;
+                $schema['crew_id'] = $crew_id;
+                Schema::Create($schema);


The variable $schema is being used as an array but was previously assigned a model instance from the query. This will cause a runtime error. Should initialize as an empty array or use Schema::create() with lowercase 'c'.

Suggested change

$schema['name'] = $dbName;

$schema['crew_id'] = $crew_id;

Schema::Create($schema);

$newSchemaData = [

'name' => $dbName,

'crew_id' => $crew_id,

];

Schema::create($newSchemaData);

vqlion added 2 commits January 17, 2025 14:50

feat(schemas): schema creation command

1efba6e

- add command to create a schema for a specific team - add schema model issue: #517

feat(schemas): schema migration command

53b3a36

- add command to migrate a specific schema from a team - can provide a custom migration path for teams specific migrations issue: #517

vqlion added the New feature New feature or request label Jan 17, 2025

vqlion self-assigned this Jan 17, 2025

vqlion linked an issue Jan 17, 2025 that may be closed by this pull request

[NEW FEATURE] Creation of specific schemas for each team #517

Open

vqlion added 2 commits January 17, 2025 16:56

feat(schemas): create team-specific migration folder

b9f20c7

the create schema command also creates a migration folder for the team issue: #517

test(schemas): add tests

6c371b1

- test creating a new custom schema for a team - test migrate to a custom schema issue: #517

vqlion marked this pull request as ready for review January 21, 2025 15:40

vqlion requested a review from lduf January 21, 2025 15:41

lduf reviewed Jan 25, 2025

View reviewed changes

feat(schemas): error handling

ace6224

add error handling to migrate command call issue: #517

lduf approved these changes Feb 18, 2025

View reviewed changes

lduf enabled auto-merge February 18, 2025 22:00

Merge branch 'master/dev' into feature/issue-517-_NEW_FEATURE_Creatio…

015f7d9

…n_of_specific_schemas_for_each_team

lduf requested a review from Copilot October 13, 2025 11:11

Copilot AI reviewed Oct 13, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: ✨ [NEW FEATURE] Creation of specific schemas for each team#519

feat: ✨ [NEW FEATURE] Creation of specific schemas for each team#519
vqlion wants to merge 6 commits into
master/devfrom
feature/issue-517-_NEW_FEATURE_Creation_of_specific_schemas_for_each_team

vqlion commented Jan 17, 2025

Uh oh!

lduf Jan 22, 2025

Uh oh!

vqlion Jan 31, 2025 •

edited

Loading

Uh oh!

sonarqubecloud Bot commented Jan 31, 2025

Uh oh!

sonarqubecloud Bot commented Mar 10, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 13, 2025

Uh oh!

Copilot AI Oct 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	Use Illuminate\Database\Eloquent\SoftDeletes;
	use Illuminate\Database\Eloquent\SoftDeletes;

-                $schema['name'] = $dbName;
-                $schema['crew_id'] = $crew_id;
-                Schema::Create($schema);
+                $newSchemaData = [
+                    'name' => $dbName,
+                    'crew_id' => $crew_id,
+                ];
+                Schema::create($newSchemaData);

Conversation

vqlion commented Jan 17, 2025

Description:

Tasks to Perform:

Uh oh!

lduf Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

vqlion Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Jan 31, 2025

Quality Gate passed

Uh oh!

sonarqubecloud Bot commented Mar 10, 2025

Quality Gate passed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vqlion Jan 31, 2025 •

edited

Loading