Skip to content

feat(github-star): star prompt + first-run onboarding walkthrough #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
beruro wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat(github-star): star prompt + first-run onboarding walkthrough #514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6254d24
feat(github-star): star prompt + first-run onboarding walkthrough
beruro Jul 24, 2026
5b06027
fix(onboarding): persist migrated walkthrough outcome
beruro Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions docs/frontend-ui-audit-2026-07-22/GitHubStarSurfaces.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
# Frontend UI Audit — GitHub Star Surfaces

**Files:** `src/features/GitHubStar/GitHubStarSettingsRow.tsx`, `src/features/GitHubStar/GitHubStarReminder.tsx`, `src/modules/MainApp/Settings/sections/GeneralSection.tsx`, `src/modules/SetupWalkthrough/index.tsx`, `src/modules/shared/layouts/GlobalModals.tsx`
**Date:** 2026-07-22
**Auditor:** ORGII agent session

## D1 — Raw HTML vs Design System

| Line | Element | Verdict | Reason | Suggested change |
| ---------------------------------- | ------------------------------------------------- | ---------------- | ----------------------------------------------------------------------------------------------------------- | ---------------- |
| `GitHubStarSettingsRow.tsx:65-107` | Design-system `Button` actions | keep with reason | Star, fallback, error, and busy states all use the shared Button component. | — |
| `GitHubStarReminder.tsx:55-112` | Shared `Modal` and design-system `Button` actions | keep with reason | The reminder reuses the established modal and button contracts instead of introducing raw interactive HTML. | — |
| `GitHubStarSettingsRow.tsx:98` | Status `<span>` | keep with reason | Non-interactive success text; semantic status is supplied by the adjacent live region. | — |

## D2 — Arbitrary Tailwind Value vs Token

| Line | Value | Verdict | Reason | Suggested change |
| ---- | ---------------------------------------------------------- | ---------------- | ----------------------------------------------------------------------- | ---------------- |
| — | No arbitrary color, CSS-variable, hex, RGB, or HSL classes | keep with reason | Surfaces use project tokens such as `text-success-6` and `text-text-3`. | — |

## D3 — Hardcoded Sizes / Colors

| Line | Value | Verdict | Reason | Suggested change |
| -------------------------------------------------------------------------- | --------------------------------------------------------- | ---------------- | ------------------------------------------------------------------------------------------------------------------------ | ---------------- |
| `GitHubStarReminder.tsx:88,90` and `GitHubStarSettingsRow.tsx:68,79,90,99` | 14px Lucide icon sizes | keep with reason | Matches the shared small-Button icon grid and is a deliberate optical micro-size. | — |
| `GitHubStarReminder.tsx:58` | Modal width `420` | keep with reason | Modal accepts a numeric content width; 420px provides space for three actions without introducing a reusable token need. | — |
| — | No raw color literals or arbitrary Tailwind pixel classes | keep with reason | Layout uses the project spacing scale and design tokens. | — |

## D4 — Accessibility

| Line | Element | Verdict | Reason | Suggested change |
| ----------------------------------- | ------------------------- | ---------------- | --------------------------------------------------------------------------------------------------- | ---------------- |
| `GitHubStarSettingsRow.tsx:117-124` | Polite status live region | keep with reason | Announces loading, fallback reason, and confirmed success; `aria-busy` mirrors actual pending work. | — |
| `GitHubStarReminder.tsx:64-100` | Reminder actions | keep with reason | Every action is a semantic Button with visible translated text; icons are decorative. | — |
| `GitHubStarReminder.tsx:108-110` | Reminder live region | keep with reason | Announces controller status while preserving visible content stability. | — |

## D5 — Visual Patterns Observed

- Settings presentation reuses `SectionRow` and `SectionContainer`; it does not create a parallel settings-row pattern.
- Reminder presentation reuses the canonical `Modal` and Button footer vocabulary.
- Controller logic is shared by Settings and reminder surfaces, preventing visual state semantics from drifting between entry points.

## Summary

- 0 fixes recommended
- 10 findings kept with documented reason
- 0 abstraction candidates
- Total source changes in this audit: 0; this report reviews the already-implemented feature without mixing audit-only fixes into the report pass.
1 change: 1 addition & 0 deletions src-tauri/crates/integrations/src/github/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ pub mod client;
pub mod commands;
pub mod detect;
pub mod profile;
pub mod star;
Loading
Loading