Skip to content

Specify that gcs_endpoint must use base API URL only #158 #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Its-Alex wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Specify that gcs_endpoint must use base API URL only #158 #160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pg_back.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,8 @@ delete_uploaded = "no"
# Google Cloud Storage (GCS) Access information. Bucket is mandatory. If the
# path to the key file is empty, the GOOGLE_APPLICATION_CREDENTIALS environment
# variable is used.
# Note: when using a custom gcs_endpoint, do not specify https:// just use the
# base API URL
Comment on lines +172 to +173
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added note is likely misleading: gcs_endpoint is passed verbatim to option.WithEndpoint() (upload.go) and generally needs to be a full URL including scheme (e.g. https://...). The problem described in #158 is usually caused by including extra path segments like /b or the bucket in the endpoint; consider rewording to explicitly say the endpoint must be the base GCS JSON API endpoint (e.g. https://storage.googleapis.com/storage/v1/) and must not include /b or the bucket name, rather than advising users to omit https:// entirely.

Suggested change
# Note: when using a custom gcs_endpoint, do not specify https:// just use the
# base API URL
# Note: when using a custom gcs_endpoint, it is passed verbatim to the client
# and should be the base GCS JSON API endpoint as a full URL, including scheme
# (for example: https://storage.googleapis.com/storage/v1/). Do not append /b
# or the bucket name to this endpoint.

Copilot uses AI. Check for mistakes.
# gcs_bucket =
# gcs_endpoint =
# gcs_keyfile =
Expand Down
Loading