Allow to change disk log destination#148
Conversation
jefryjacky
left a comment
There was a problem hiding this comment.
Can you create builder for set directory and also the set the folder name so it will be more flexible. because sometime user only want to change the folder name only.
|
@jefryjacky I don't quite understand your words... You could pass a directory name like |
|
I mean the "logger" the "logger" is hardcoded, I suggest to be able to custom that name. |
|
@jefryjacky If changing the subdirectory instead of "logger" is the only thing the coder wants to do, why doesn't him/her pass |
|
Sorry for the late response and thanks for the pull request. I wasn't able to review anything this time period. Apart from a few things, all looks good to me. Would you mind to make the following changes? Then we can merge and release a version for this.
|
|
I have changed some, but with one thing not sure: |
DiskLogStrategy.DiskLogStrategyfromCsvFormatStrategytoDiskLogStrategy.Builder.