Silence warnings converting between signed and unsigned types without an explicit cast#25
Open
MichaelBuckley wants to merge 2 commits intoorlp:masterfrom
Open
Silence warnings converting between signed and unsigned types without an explicit cast#25MichaelBuckley wants to merge 2 commits intoorlp:masterfrom
MichaelBuckley wants to merge 2 commits intoorlp:masterfrom
Conversation
ekcdd
pushed a commit
to ekcdd/ed25519
that referenced
this pull request
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Apologies for dropping this pull request on you out of the blue. An open-source library I depend on recently added ed25519 as a dependency, and that library has rather strict warning settings. This has resulted in 23 warnings when building my project. Since I try to eliminate all warnings, I would be very grateful if you would accept these changes.
Most of the warnings were caused by implicit conversions between signed and unsigned variables. I have done my best to not alter the behavior of the program, just to add explicit casts to silence the warnings.
Thank you for your time.