Add support for large messages#9
Open
evilrix wants to merge 1 commit intoorlp:masterfrom
evilrix:master
Open
Conversation
|
This is very useful, I added my own variant of this when I started using ed25519. I know reviewing crypto contributions is a pain but it would be nice to have this out the box. |
Rather than having to verify a whole memory buffer in one go, allow chunks of memory to be processed using begin, update and end verify functions. The begin function starts a new verify process, returning an opaque context handle. The update function can then be called multiple times with this context and blocks of memory to process memory in chuncks. Finally the end function is called with the context to end the verify process and get the result.
|
thanks for the pr, I'll patch my source tree |
|
Hi, It can be used inside a ESP8266 12F or Arduino or Both? Thanks. |
|
If you're signing large amounts of data are you supposed to generate a SHA512 of the data you want to sign and then sign that 512 bit hash? Do the same (calculate the SHA512 of the input) then verify the hash at the other end. If so the facilities for that already exist in the library, ie the SHA512 can be fed in blocks. It should also be faster for signing as you only have to scan the file once, verifying the signature will, of course be exactly the same speed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than having to verify a whole memory buffer in one go, allow chunks of
memory to be processed using begin, update and end verify functions. The begin
function starts a new verify process, returning an opaque context handle. The
update function can then be called multiple times with this context and blocks
of memory to process memory in chuncks. Finally the end function is called with
the context to end the verify process and get the result.