Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I like your work! It's the only extension working with current Safari without having to install some special other plugins...
I did some additions to save all the options to the config.
Go through the commits - I also refactored my code, maybe easier to understand step by step.
Initially I wanted to take a look at how to implement saving the selected font and size to config at all, because it doesn't work in my installed version. After I forked, I realized, that code for it already exists and fortunately works here. Don't know the differences between the officially installed version and the source, but I can also live with my fork :-) However, we have to check.
However, after I saw that the other options were missing, I added them.
Greetings from Germany
KSi