Skip to content

Use array flip + array keys to check no duplicate category ID exists #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acidvertigo wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Use array flip + array keys to check no duplicate category ID exists #358

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a7486e
Return directly lambda function instead to assign it to a variable
acidvertigo Jun 11, 2015
350cd9c
Update check for duplicate category ID removal
acidvertigo Jun 11, 2015
0e6c961
Remove temp_array as it is unneded
acidvertigo Jun 11, 2015
0043ccd
Change with array_flip as it is faster
acidvertigo Jun 11, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions catalog/includes/functions/general.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1295,15 +1295,7 @@ function tep_parse_category_path($cPath) {
}, explode('_', $cPath));

// make sure no duplicate category IDs exist which could lock the server in a loop
$tmp_array = array();
$n = sizeof($cPath_array);
for ($i=0; $i<$n; $i++) {
if (!in_array($cPath_array[$i], $tmp_array)) {
$tmp_array[] = $cPath_array[$i];
}
}

return $tmp_array;
return array_keys(array_flip($cPath_array));
}

////
Expand Down