fix(csvpp): fix bugs and update documentation from audit#14
Merged
Conversation
- Update Go version requirement from 1.24 to 1.25 - Add GOEXPERIMENT=jsonv2 requirement for csvpputil package - Add build/test command examples with the experiment flag Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add r.line++ in ReadAll loop so ParseError reports correct line numbers - Export ReaderLine helper for testing - Add TestReader_ReadAll_LineTracking test Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add nil check for field parameter in formatField - Add TestWriter_Write_NilField test Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix variable names reader/writer to r/w to clarify io.Reader/io.Writer usage - Replace redundant Struct Tags section with reference to Struct Mapping Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add filter key bindings (/, Enter, Esc) to Key Bindings table - Document column:value filter syntax - Add GOEXPERIMENT=jsonv2 to install and build commands Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Document WithYAMLCapacity functional option for YAMLArrayWriter - Add usage example in code snippet Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReadAll()line number tracking bug —ParseError.Linealways reported line 1Writer.formatFieldwhen*Fieldis nilREADME.mdrequirements to Go 1.25 +GOEXPERIMENT=jsonv2GOEXPERIMENT=jsonv2to CLI install/build commandsMarshal/UnmarshalexampleWithYAMLCapacityoption in csvpputil READMETest plan
TestReader_ReadAll_LineTracking— verifies line counter increments correctlyTestWriter_Write_NilField— verifies nil field does not panicGOEXPERIMENT=jsonv2 go test ./...🤖 Generated with Claude Code