feat(csvpp): update implementation to draft-mscaldas-csvpp-02#18
Merged
feat(csvpp): update implementation to draft-mscaldas-csvpp-02#18
Conversation
- Rename parseArrayDelimiter to parseArrayDelimiterWithDepth to accept depth parameter - Return error when empty brackets [] are used at depth > 0 (nested level) - Per draft-02, default tilde delimiter applies only to top-level arrays - Update tests to use explicit delimiters for nested arrays - Add test cases for nested empty bracket rejection Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Update doc.go package comment to reference draft-mscaldas-csvpp-02 - Add note about tilde default applying only to top-level arrays - Update README.md specification link to draft-02 - Add Conformance Notes section documenting leaf-only quoting as not yet implemented - Clarify default delimiter scope in README.md Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[]in nested arrays per draft-02 (default tilde applies only to top-level arrays)Changes
Code
parseArrayDelimitertoparseArrayDelimiterWithDepthwith depth parameter[]is used at depth > 0 (nested level)Docs
doc.goandREADME.mdto reference draft-02README.mdfor leaf-only quoting limitationTest plan
go test ./...passesGOEXPERIMENT=jsonv2 go test ./...passesgo vet ./...passes[]correctly rejected at depth > 0[;](explicit delimiter) works at any depth[]continues to default to~🤖 Generated with Claude Code