feat: Add worker discovery, migrate CLI to REST, harden validation#139
Merged
feat: Add worker discovery, migrate CLI to REST, harden validation#139
Conversation
Contributor
|
Thank you for contributing to this project! 😊🕹️ |
- Add GET /job/workers endpoint with CLI command for fleet discovery - Migrate all `client job` CLI commands from direct NATS to REST API - Rename --host/-H CLI flag to --target/-T across all commands - Add input validation for path params (interfaceName, job ID), query params (target_hostname, status), and missing 400 responses - Add public and integration tests for all validation cases 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
retr0h
force-pushed
the
feat/validation-and-rest-migration
branch
from
8d92c76 to
6905379
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #139 +/- ##
===========================================
- Coverage 100.00% 99.79% -0.21%
===========================================
Files 92 99 +7
Lines 2064 2384 +320
===========================================
+ Hits 2064 2379 +315
- Misses 0 4 +4
- Partials 0 1 +1
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Add test cases for _all broadcast paths in all API handler public and integration tests, plus job client *All and ListWorkers methods. Brings API handler coverage to 100% and job client to 99.6%. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client jobCLI commands from direct NATS to REST API🤖 Generated with Claude Code