refactor(cmd): Standardize server/worker lifecycle#149
Merged
Conversation
Unify all three server commands (API, worker, NATS) on a shared Lifecycle interface with non-blocking Start()/Stop(ctx) and a runServer helper that handles signal blocking, shutdown timeout, and cleanup ordering. Key fixes in the worker: - Add graceful drain via wg.Wait() in Stop (was missing) - Add 10s shutdown timeout (was missing) - Add NATS connection cleanup (was leaking) - Remove unnecessary double goroutine layer Also update CLAUDE.md with missing doc references (principles, api-guidelines, configuration, system-architecture) and add a reading path to the contributing guide. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
Thank you for contributing to this project! 😊🕹️ |
Rename all task files to use conventional commit type prefixes (feat-, fix-, docs-, refactor-, test-, chore-) for consistency with the project's commit message conventions. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Strip "Feature: ", "Phase N: " prefixes and unnecessary quotes from task titles since the filename already conveys the type. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #149 +/- ##
===========================================
- Coverage 100.00% 99.92% -0.08%
===========================================
Files 99 99
Lines 2541 2543 +2
===========================================
Hits 2541 2541
- Misses 0 2 +2
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unify all three server commands (API, worker, NATS) on a shared Lifecycle interface with non-blocking Start()/Stop(ctx) and a runServer helper that handles signal blocking, shutdown timeout, and cleanup ordering.
Key fixes in the worker:
Also update CLAUDE.md with missing doc references (principles, api-guidelines, configuration, system-architecture) and add a reading path to the contributing guide.
🤖 Generated with Claude Code