main: dont allow multi-string flags#540
Closed
supakeen wants to merge 2 commits into
Closed
Conversation
Cobra by default lets us pass string values multiple times and uses the last one. This is confusing and was reported to be confusing on the `--blueprint` flag. Let's address it there with a new type that only allows a single value to be set. We might want to expand this to all string-type flags. Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>
Previously we applied the set once idiom only to the `--blueprint` flag. I feel that the behavior is surprising and should be applied to all string-typed flags. This commit does just that. Also does the same for StringVar's. Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we applied the set once idiom only to the
--blueprintflag.I feel that the behavior is surprising and should be applied to all
string-typed flags. This commit does just that.
Also does the same for StringVar's.
Rebased on top of #539.