Re-enable the bootc-image-builder tests#550
Open
achilleas-k wants to merge 2 commits into
Open
Conversation
Start running the bib (bootc-image-builder) tests again to prepare for finalising the merge. This reverts commit 52cc479.
This is the README that's in the test/ directory of the bootc-image-builder repository. Add it for reference. It might be later merged into a general testing document with instructions for running the bootc-based tests.
Member
|
@achilleas-k Will you be fixing them in this PR? I thought enabling them as part of the merge PR would make 'more sense'? |
Member
Author
|
I had a quick look at the code changes since we did the previous merge and I think there's nothing missing. I opened this PR to see if I missed anything, if the tests catch anything. So this PR might turn into an update-and-fix PR. Or we might do the other thing. We should talk next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start running the bib (bootc-image-builder) tests again to prepare for finalising the merge.