Skip invalid plugins entries for help and plugin commands#398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #395, an invalid
pluginsentry inserverless.ymlfails initialization before any command runs. That is the right default, but it also affects the two contexts that were already lenient about plugins that are listed in the configuration without being installed: printing help and running thepluginmanagement commands. In particular, a broken entry such asserverless-webpack@1.2.3made it impossible to runserverless plugin uninstall, because the command failed on the very configuration it is meant to fix, leaving hand-editing the file as the only way out.This change reuses the existing leniency rule instead of introducing a new one.
parsePluginsObjectgains atolerateInvalidEntriesoption that drops invalid entries with a warning instead of throwing, andresolveServicePluginsenables it under exactly the condition that already skips plugins failing withPLUGIN_NOT_FOUND: when help is requested or when the current command ishelporplugin. Everywhere else the validation continues to fail hard, the packaging code path keeps the strict default, and the upgrade guide now mentions the softer behavior in its section onpluginsvalidation.