Harden JS file address property access#400
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from #396, this wraps the property access step of file address resolution in proper error handling. A property read can throw synchronously, either from a Proxy get handler or from a plain getter defined on the file's result, and until now such a crash escaped as a raw exception instead of the coded errors every other failure mode in that loop produces. The access now surfaces as a ServerlessError carrying the address and file name, in line with the existing function and promise rejection paths.
While there, the own-or-proxy traversal condition moves into a shared canFollowProperty helper in the safe-object util, next to hasOwn. It encodes the rule from #396 in one place: own properties are always followed, and Proxy-backed values are followed through their get handler except for the prototype-internal keys. Behaviour is unchanged; this just gives the rule a single home instead of an inline condition in the file source.