Integration: signup wiring with stubs for API client and auth context#53
Integration: signup wiring with stubs for API client and auth context#53Prajeeth-12 wants to merge 1 commit intomainfrom
Conversation
|
used some placeholder values for APIs , |
Munazzah-Rakhangi
left a comment
There was a problem hiding this comment.
Changes required before approval
Thanks for the integration work — the API wiring and signup flow connect successfully, but the frontend validation logic needs improvement. Right now, the form allows invalid or incomplete data to pass through and still create an account.
Issues observed:
Name: Accepts numeric input like “1234”. It should only allow alphabetic characters.
→ Show error: “Enter a valid name.”
Gender: Field can not be left empty. This should be mandatory.
→ Show error: “Please select a gender.”
Phone: Accepts non-numeric input like “abcd”. It should allow only valid phone numbers (digits, 10–15 chars).
→ Show error: “Enter a valid phone number.”
Password: Accepts weak passwords (e.g., “123456”). Must enforce:
Minimum 8 characters
At least 1 uppercase letter
At least 1 special character
→ Show error: “Please meet the password requirements.”
Action required:
Please add client-side validation for these fields before submission and prevent API calls when the input is invalid. Once this validation is in place, I’ll re-test and approve the PR.
No description provided.