Add deadcode analysis to CI; fix existing dead code#824
Merged
justaugustus merged 2 commits intomainfrom Apr 22, 2026
Merged
Conversation
Closed
Agent-Logs-Url: https://github.com/ossf/allstar/sessions/83a1b24b-e7de-4155-8a32-6ea3a925d2af Co-authored-by: justaugustus <567897+justaugustus@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add deadcode tool to development workflow and CI
Add deadcode analysis to CI; fix existing dead code
Apr 21, 2026
dosubot
Bot
added
the
size:XS
jeffmendoza
approved these changes
Apr 22, 2026
justaugustus
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deadcode(unlikeunused) traces reachability frommain, catching functions that exist in production code but are only exercised by tests. This adds it to CI and removes the one dead function it found.Changes
.github/workflows/pr.yaml: Newdeadcodejob — installsgolang.org/x/tools/cmd/deadcodeand runsdeadcode ./cmd/allstar/...on every PR.pkg/policies/scorecard/sarif.go: RemoveclearSARIFHashes— unreachable frommain.pkg/policies/scorecard/sarif_test.go: MoveclearSARIFHasheshere as a test-scoped helper, where it belongs.