feat: add Secret Scanning policy#841
Conversation
Signed-off-by: bmendonca3 <208517100+bmendonca3@users.noreply.github.com>
|
@bmendonca3 — While we appreciate contributions, we are sensitive to the submission of AI-assisted / AI-autonomous contributions, as they can overload maintainers. I mention this because I see 7 submissions from you across the project today alone and I can see mentions of OpenClaw on your GitHub profile. Scorecard / Allstar currently does not have a project-specific policy, but I would strongly suggest a [human] read of the forthcoming OpenSSF AI contribution policy to understand the concerns that maintainers across the foundation have around interacting with AI submissions. Once a human has acknowledged this note, we will consider review. |
|
Thanks Stephen, I understand.. I read through the policy draft and get where you're coming from I do own the changes though. I reviewed them, ran the tests, and can explain the reasoning / tradeoffs if needed. I’ll hold off on opening more Scorecard / Allstar PRs for now |
|
This pull request has been marked stale because it has been open for 10 days with no activity |
Summary
Adds a Secret Scanning policy for Allstar.
This policy:
secret_scanning.yamlfor org/repo configurationdisabledsecurity_and_analysisdata as unavailable, not as disabledfixaction by enabling secret scanning when GitHub reports it as disabledThis intentionally leaves push protection out of scope for the first pass.
Fixes #363
Testing
PATH=/tmp/go/bin:$PATH go test ./pkg/policies/secretscanningPATH=/tmp/go/bin:$PATH go test ./pkg/policies/...PATH=/tmp/go/bin:$PATH go test ./...PATH=/tmp/go/bin:$PATH go build ./...PATH=/tmp/go/bin:$PATH go vet ./...PATH=/tmp/go/bin:$PATH /tmp/go-tools/golangci-lint run --timeout 5m --verboseLive validation
Validated the policy-specific Check/Fix/Check path against a disposable repository:
https://github.com/bmendonca3/allstar-secret-scanning-validation-20260528152234
Using an authenticated GitHub client against this branch, the policy:
secret_scanning.status=disabledCheckresultenabled=true pass=falseFixsecret_scanning.status=enabledCheckresultenabled=true pass=trueThis validates the live GitHub API Check/Fix/Check path for this policy. It does not claim full end-to-end GitHub App installation or issue-creation coverage, which remains outside this validation pass.