Skip to content

fix: detect committer fields as untrusted input in dangerous workflows#5026

Open
avasis-ai wants to merge 2 commits intoossf:mainfrom
avasis-ai:fix/detect-committer-untrusted-input
Open

fix: detect committer fields as untrusted input in dangerous workflows#5026
avasis-ai wants to merge 2 commits intoossf:mainfrom
avasis-ai:fix/detect-committer-untrusted-input

Conversation

@avasis-ai
Copy link
Copy Markdown

Summary

The dangerous workflow check detects head_commit.author.{email,name} and commits[*].author.{email,name} as untrusted input, but does not detect the equivalent committer fields. The committer fields are equally attacker-controlled and should be flagged as dangerous.

Changes

  • Added head_commit.committer.{email,name} and commits[*].committer.{email,name} to the untrusted context pattern regex
  • Added corresponding test cases for all new patterns

References

@avasis-ai avasis-ai requested a review from a team as a code owner April 19, 2026 17:30
@avasis-ai avasis-ai requested review from justaugustus and spencerschrock and removed request for a team April 19, 2026 17:30
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant